Add --service as an option for correlate-image

[rwc9u]

Feature request description

We were trying to test out the correlate image functionality with our argocd deploys. However, service is inferred from the repo value in the image string, so it would be alot of work on our side.

We would need to

• change the base ECR repo name to update to be the service name, and update all references to this new value (e.g image builds, tagging, etc).
• We would also have to change all of our dashboards to stop embedding environment in our service names (i.e. we currently have foo-bar-staging, foo-bar-production). Granted the environment in the service name is weird and on us, but I'm not sure env was available when we started using datadog. Regardless, this is a weird edge case.

Solution

If correlate-image also took a service as a parameter and used it as part of the glue to stitch argo deploys to repo/images, it would make our usage of the product a no-brainer. Since it's still in preview I was hoping this might be added.

Additional context

No response

Command

None

[GabrielAnca]

Hi @rwc9u 👋🏻 Thanks for the proposal. We understand why this solution doesn't work for your use case. Your proposal makes total sense, but it requires a number of internal changes on our end, so I'm uncertain on when we could deliver it.

However, we have implemented an improvement that may be useful to you. When we receive a service deployment from ArgoCD:

• (new) If we find one single image which has been previously correlated using datadog-ci deployment correlate-image, we use that image for correlation (regardless of image name).
• If we find more than one image: we continue with the same behavior that existed before today: we iterate over the images in the deployed resources, if any of them has been correlated using datadog-ci deployment correlate-image and if the image includes the service name, we use it for correlation. Otherwise, we are not sure which is the correct image and we won't correlate the deployment.

Let me know if this helps!