Skip to content

Commit bc96510

Browse files
Merge pull request #2462 from DataDog/simaoseica/chore/remove-unused-structures
chore: Remove unused `objc_SessionReplayConfigurationPrivacyLevel`
2 parents e1ab2a7 + 307c7a1 commit bc96510

4 files changed

Lines changed: 3 additions & 44 deletions

File tree

DatadogSessionReplay/Sources/SessionReplay+objc.swift

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -161,36 +161,6 @@ public final class objc_SessionReplayConfiguration: NSObject {
161161
}
162162
}
163163

164-
/// Available privacy levels for content masking.
165-
@objc(DDSessionReplayConfigurationPrivacyLevel)
166-
@_spi(objc)
167-
public enum objc_SessionReplayConfigurationPrivacyLevel: Int {
168-
/// Record all content.
169-
case allow
170-
171-
/// Mask all content.
172-
case mask
173-
174-
/// Mask input elements, but record all other content.
175-
case maskUserInput
176-
177-
internal var _swift: SessionReplayPrivacyLevel {
178-
switch self {
179-
case .allow: return .allow
180-
case .mask: return .mask
181-
case .maskUserInput: return .maskUserInput
182-
}
183-
}
184-
185-
internal init(_ swift: SessionReplayPrivacyLevel) {
186-
switch swift {
187-
case .allow: self = .allow
188-
case .mask: self = .mask
189-
case .maskUserInput: self = .maskUserInput
190-
}
191-
}
192-
}
193-
194164
/// Available privacy levels for text and input masking.
195165
@objc(DDTextAndInputPrivacyLevel)
196166
@_spi(objc)

DatadogSessionReplay/Tests/DDSessionReplayTests.swift

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -121,16 +121,6 @@ class DDSessionReplayTests: XCTestCase {
121121
XCTAssertEqual(config._swift.startRecordingImmediately, startRecordingImmediately)
122122
}
123123

124-
func testPrivacyLevelsInterop() {
125-
XCTAssertEqual(objc_SessionReplayConfigurationPrivacyLevel.allow._swift, .allow)
126-
XCTAssertEqual(objc_SessionReplayConfigurationPrivacyLevel.mask._swift, .mask)
127-
XCTAssertEqual(objc_SessionReplayConfigurationPrivacyLevel.maskUserInput._swift, .maskUserInput)
128-
129-
XCTAssertEqual(objc_SessionReplayConfigurationPrivacyLevel(.allow), .allow)
130-
XCTAssertEqual(objc_SessionReplayConfigurationPrivacyLevel(.mask), .mask)
131-
XCTAssertEqual(objc_SessionReplayConfigurationPrivacyLevel(.maskUserInput), .maskUserInput)
132-
}
133-
134124
func testTextAndInputPrivacyLevelsInterop() {
135125
XCTAssertEqual(objc_TextAndInputPrivacyLevel.maskAll._swift, .maskAll)
136126
XCTAssertEqual(objc_TextAndInputPrivacyLevel.maskAllInputs._swift, .maskAllInputs)

api-surface-objc

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2345,6 +2345,8 @@ public class objc_RUMMonitor: NSObject
23452345
public func removeAttributes(forKeys keys: [String])
23462346
public func addFeatureFlagEvaluation(name: String, value: Any)
23472347
public var debug: Bool
2348+
[?] extension objc_RUMMonitor
2349+
public func _internal_sync_addError(_ error: Error,source: objc_RUMErrorSource,attributes: [String: Any])
23482350

23492351

23502352
# ----------------------------------
@@ -2381,10 +2383,6 @@ public final class objc_SessionReplayConfiguration: NSObject
23812383
@objc public var featureFlags: [String: Bool]
23822384
public required init(replaySampleRate: Float,textAndInputPrivacyLevel: objc_TextAndInputPrivacyLevel,imagePrivacyLevel: objc_ImagePrivacyLevel,touchPrivacyLevel: objc_TouchPrivacyLevel,featureFlags: [String: Bool]?)
23832385
public convenience init(replaySampleRate: Float,textAndInputPrivacyLevel: objc_TextAndInputPrivacyLevel,imagePrivacyLevel: objc_ImagePrivacyLevel,touchPrivacyLevel: objc_TouchPrivacyLevel)
2384-
public enum objc_SessionReplayConfigurationPrivacyLevel: Int
2385-
case allow
2386-
case mask
2387-
case maskUserInput
23882386
public enum objc_TextAndInputPrivacyLevel: Int
23892387
case maskSensitiveInputs
23902388
case maskAllInputs

api-surface-swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -511,6 +511,7 @@ public protocol RUMMonitorProtocol: RUMMonitorViewProtocol, AnyObject
511511
func stopAction(type: RUMActionType,name: String?,attributes: [AttributeKey: AttributeValue])
512512
func addFeatureFlagEvaluation(name: String,value: Encodable)
513513
var debug: Bool
514+
func addError(error: Error,source: RUMErrorSource,attributes: [AttributeKey: AttributeValue],completionHandler: @escaping CompletionHandler)
514515
public protocol RUMMonitorViewProtocol: AnyObject
515516
func addViewAttribute(forKey key: AttributeKey, value: AttributeValue)
516517
func addViewAttributes(_ attributes: [AttributeKey: AttributeValue])

0 commit comments

Comments
 (0)