code fix: don't throw inside AggressiveInlining

Author: lucaspimentel

tracer/src/Datadog.Trace/Ci/Coverage/CoverageReporter.cs

@@ -29,7 +29,15 @@ internal static CoverageEventHandler Handler
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         get => _handler;
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        set => _handler = value ?? throw new ArgumentNullException(nameof(value));
+        set
+        {
+            if (value == null!)
+            {
+                ThrowHelper.ThrowArgumentNullException(nameof(value));
+            }
+
+            _handler = value;
+        }
     }
 
     internal static CoverageContextContainer? Container => _handler.Container;

tracer/src/Datadog.Trace/Debugger/ExceptionAutoInstrumentation/ExceptionNormalizer.cs

@@ -30,7 +30,8 @@ internal int NormalizeAndHashException(string exceptionString, string outerExcep
         {
             if (string.IsNullOrEmpty(exceptionString))
             {
-                throw new ArgumentException(@"Exception string cannot be null or empty", nameof(exceptionString));
+                ThrowHelper.ThrowArgumentException(@"Exception string cannot be null or empty", nameof(exceptionString));
+                return 0; // code never reached
             }
 
             var fnvHashCode = HashLine(outerExceptionType.AsSpan(), Fnv1aHash.FnvOffsetBias);
@@ -104,7 +105,8 @@ internal List<string> ParseFrames(string exceptionString)
         {
             if (string.IsNullOrEmpty(exceptionString))
             {
-                throw new ArgumentException(@"Exception string cannot be null or empty", nameof(exceptionString));
+                ThrowHelper.ThrowArgumentException(@"Exception string cannot be null or empty", nameof(exceptionString));
+                return null; // code never reached
             }
 
             var results = new List<string>();

tracer/src/Datadog.Trace/Util/FixedSizeArrayPool.cs

@@ -6,7 +6,6 @@
 
 using System;
 using System.Collections.Concurrent;
-using System.Diagnostics;
 using System.Runtime.CompilerServices;
 using System.Threading;
 
@@ -115,7 +114,7 @@ public T[] Array
 #if DEBUG
                 if (_array is null)
                 {
-                    throw new ObjectDisposedException(nameof(ArrayPoolItem));
+                    ThrowHelper.ThrowObjectDisposedException(nameof(ArrayPoolItem));
                 }
 #endif
                 return _array ?? [];

tracer/src/Datadog.Trace/Util/SpanCharSplitter.cs

@@ -19,7 +19,12 @@ internal readonly ref struct SpanCharSplitter
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public SpanCharSplitter(string source, char separator, int count)
     {
-        _source = source ?? throw new ArgumentNullException(nameof(source));
+        if (source == null!)
+        {
+            ThrowHelper.ThrowArgumentNullException(nameof(source));
+        }
+
+        _source = source;
         _separator = separator;
         _count = count;
     }