Commit 2b5dfce
Narrow the warning to the third-party endpoint getter
Downgrading the whole catch also suppressed error telemetry for defects in
our own collection path (EndpointsCollection.CollectEndpoints,
ReportEndpoints, duck casts), which the logging guidance requires to stay
at Log.Error.
Wrap only the EndpointDataSource.Endpoints evaluation, the third-party
code we cannot control, and restore Log.Error on the outer catch.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent 186e74f commit 2b5dfce
1 file changed
Lines changed: 20 additions & 7 deletions
File tree
- tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AspNetCore/EndpointsCollection
Lines changed: 20 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
57 | 58 | | |
58 | 59 | | |
59 | 60 | | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
| 61 | + | |
66 | 62 | | |
67 | 63 | | |
68 | 64 | | |
| |||
89 | 85 | | |
90 | 86 | | |
91 | 87 | | |
92 | | - | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
93 | 106 | | |
94 | 107 | | |
95 | 108 | | |
| |||
0 commit comments