Skip to content

Commit 656cebf

Browse files
authored
Remove comments on WAF diagnostics object handling
Removed comments about WAF diagnostics object allocation and reuse.
1 parent 0312d34 commit 656cebf

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

tracer/src/Datadog.Trace/AppSec/Waf/Initialization/WafConfigurator.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -252,9 +252,6 @@ internal UpdateResult Update(IntPtr wafBuilderHandle, ConfigurationState configu
252252
var configObj = encoded.ResultDdwafObject;
253253
var path = config.Key;
254254

255-
// the WAF allocates a fresh diagnostics object on every call and overwrites the
256-
// one it is given without freeing it, so it can't be reused across the loop: only
257-
// the last one is reported, the previous ones have to be released here or they leak
258255
var configDiagnostics = default(DdwafObjectStruct);
259256
if (!_wafLibraryInvoker.BuilderAddOrUpdateConfig(wafBuilderHandle, path, ref configObj, ref configDiagnostics))
260257
{

0 commit comments

Comments
 (0)