Align ThrowHelper test stub with real signatures

Remove 0-arg overloads from ThrowHelperStub that don't exist in the
real ThrowHelper. Convert ShouldFixZeroArgConstructor to a negative
test since there's no matching overload.

🤖 Co-Authored-By: Claude Code <noreply@anthropic.com>

Author: lucaspimentel

tracer/src/Datadog.Trace.Tools.Analyzers.CodeFixes/ThrowInInlinedMethodAnalyzer/ThrowInInlinedMethodCodeFixProvider.cs

@@ -29,20 +29,20 @@ public class ThrowInInlinedMethodCodeFixProvider : CodeFixProvider
     {
         private const string ThrowHelperUsingNamespace = "Datadog.Trace.Util";
 
-        private static readonly Dictionary<string, (string MethodName, int MaxArgs)> SupportedExceptions
-            = new Dictionary<string, (string, int)>
+        private static readonly Dictionary<string, (string MethodName, int MinArgs, int MaxArgs)> SupportedExceptions
+            = new Dictionary<string, (string, int, int)>
             {
-                ["System.ArgumentNullException"] = ("ThrowArgumentNullException", 1),
-                ["System.ArgumentOutOfRangeException"] = ("ThrowArgumentOutOfRangeException", 3),
-                ["System.ArgumentException"] = ("ThrowArgumentException", 2),
-                ["System.InvalidOperationException"] = ("ThrowInvalidOperationException", 1),
-                ["System.Exception"] = ("ThrowException", 1),
-                ["System.InvalidCastException"] = ("ThrowInvalidCastException", 1),
-                ["System.IndexOutOfRangeException"] = ("ThrowIndexOutOfRangeException", 1),
-                ["System.NotSupportedException"] = ("ThrowNotSupportedException", 1),
-                ["System.Collections.Generic.KeyNotFoundException"] = ("ThrowKeyNotFoundException", 1),
-                ["System.NullReferenceException"] = ("ThrowNullReferenceException", 1),
-                ["System.ObjectDisposedException"] = ("ThrowObjectDisposedException", 1),
+                ["System.ArgumentNullException"] = ("ThrowArgumentNullException", 1, 1),
+                ["System.ArgumentOutOfRangeException"] = ("ThrowArgumentOutOfRangeException", 1, 3),
+                ["System.ArgumentException"] = ("ThrowArgumentException", 1, 2),
+                ["System.InvalidOperationException"] = ("ThrowInvalidOperationException", 1, 1),
+                ["System.Exception"] = ("ThrowException", 1, 1),
+                ["System.InvalidCastException"] = ("ThrowInvalidCastException", 1, 1),
+                ["System.IndexOutOfRangeException"] = ("ThrowIndexOutOfRangeException", 1, 1),
+                ["System.NotSupportedException"] = ("ThrowNotSupportedException", 1, 1),
+                ["System.Collections.Generic.KeyNotFoundException"] = ("ThrowKeyNotFoundException", 1, 1),
+                ["System.NullReferenceException"] = ("ThrowNullReferenceException", 1, 1),
+                ["System.ObjectDisposedException"] = ("ThrowObjectDisposedException", 1, 1),
             };
 
         /// <inheritdoc />
@@ -112,7 +112,7 @@ private static bool TryGetThrowHelperMethod(
             }
 
             var argCount = creation.ArgumentList?.Arguments.Count ?? 0;
-            if (argCount > entry.MaxArgs)
+            if (argCount < entry.MinArgs || argCount > entry.MaxArgs)
             {
                 return false;
             }

tracer/test/Datadog.Trace.Tools.Analyzers.Tests/ThrowInInlinedMethodAnalyzer/ThrowInInlinedMethodCodeFixProviderTests.cs

@@ -22,35 +22,25 @@ public class ThrowInInlinedMethodCodeFixProviderTests
 {
     private const string DiagnosticId = Analyzers.ThrowInInlinedMethodAnalyzer.Diagnostics.DiagnosticId;
 
-    // Minimal ThrowHelper stub so the fixed code compiles in the test harness
+    // Minimal ThrowHelper stub matching real signatures so the fixed code compiles in the test harness
     private const string ThrowHelperStub = """
 
         namespace Datadog.Trace.Util
         {
             internal static class ThrowHelper
             {
-                internal static void ThrowArgumentNullException() => throw new System.ArgumentNullException();
                 internal static void ThrowArgumentNullException(string paramName) => throw new System.ArgumentNullException(paramName);
-                internal static void ThrowArgumentOutOfRangeException() => throw new System.ArgumentOutOfRangeException();
                 internal static void ThrowArgumentOutOfRangeException(string paramName) => throw new System.ArgumentOutOfRangeException(paramName);
                 internal static void ThrowArgumentOutOfRangeException(string paramName, string message) => throw new System.ArgumentOutOfRangeException(paramName, message);
                 internal static void ThrowArgumentOutOfRangeException(string paramName, object actualValue, string message) => throw new System.ArgumentOutOfRangeException(paramName, actualValue, message);
-                internal static void ThrowArgumentException() => throw new System.ArgumentException();
                 internal static void ThrowArgumentException(string message) => throw new System.ArgumentException(message);
                 internal static void ThrowArgumentException(string message, string paramName) => throw new System.ArgumentException(message, paramName);
-                internal static void ThrowInvalidOperationException() => throw new System.InvalidOperationException();
                 internal static void ThrowInvalidOperationException(string message) => throw new System.InvalidOperationException(message);
-                internal static void ThrowException() => throw new System.Exception();
                 internal static void ThrowException(string message) => throw new System.Exception(message);
-                internal static void ThrowInvalidCastException() => throw new System.InvalidCastException();
                 internal static void ThrowInvalidCastException(string message) => throw new System.InvalidCastException(message);
-                internal static void ThrowIndexOutOfRangeException() => throw new System.IndexOutOfRangeException();
                 internal static void ThrowIndexOutOfRangeException(string message) => throw new System.IndexOutOfRangeException(message);
-                internal static void ThrowNotSupportedException() => throw new System.NotSupportedException();
                 internal static void ThrowNotSupportedException(string message) => throw new System.NotSupportedException(message);
-                internal static void ThrowKeyNotFoundException() => throw new System.Collections.Generic.KeyNotFoundException();
                 internal static void ThrowKeyNotFoundException(string message) => throw new System.Collections.Generic.KeyNotFoundException(message);
-                internal static void ThrowNullReferenceException() => throw new System.NullReferenceException();
                 internal static void ThrowNullReferenceException(string message) => throw new System.NullReferenceException(message);
             }
         }
@@ -271,8 +261,10 @@ void TestMethod()
     }
 
     [Fact]
-    public async Task ShouldFixZeroArgConstructor()
+    public async Task ShouldNotFixZeroArgConstructor()
     {
+        // Zero-arg constructors have no matching ThrowHelper overload, so no fix should be offered.
+        // The diagnostic is still reported, but the source is unchanged.
         const string source = """
             using System;
             using System.Runtime.CompilerServices;
@@ -287,25 +279,11 @@ void TestMethod()
             }
             """;
 
-        const string fix = """
-            using System;
-            using System.Runtime.CompilerServices;
-            using Datadog.Trace.Util;
-
-            class TestClass
-            {
-                [MethodImpl(MethodImplOptions.AggressiveInlining)]
-                void TestMethod()
-                {
-                    ThrowHelper.ThrowInvalidOperationException();
-                }
-            }
-            """;
-
         var expected = new DiagnosticResult(DiagnosticId, DiagnosticSeverity.Warning)
             .WithLocation(0)
             .WithArguments("TestMethod");
-        await Verifier.VerifyCodeFixAsync(source + ThrowHelperStub, expected, fix + ThrowHelperStub);
+
+        await Verifier.VerifyCodeFixAsync(source, expected, source);
     }
 
     [Fact]