fix(ffe): isolate malformed flag configuration - #9024
Conversation
This reverts commit 2077a24.
Bring the canonical evaluation fixture branch onto current master as the base for regex conformance coverage. Environment: Datadog workspace
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (9024) and master.
|
|||||||||||||||||||||||||||||||||||
| Metric | Master (Mean ± 95% CI) | Current (Mean ± 95% CI) | Change | Status |
|---|---|---|---|---|
| .NET Framework 4.8 - Baseline | ||||
| duration | 190.44 ± (190.41 - 191.25) ms | 210.14 ± (209.99 - 210.82) ms | +10.3% | ❌⬆️ |
| .NET Framework 4.8 - Bailout | ||||
| duration | 194.15 ± (194.07 - 194.52) ms | 215.59 ± (215.01 - 216.13) ms | +11.0% | ❌⬆️ |
| .NET Framework 4.8 - CallTarget+Inlining+NGEN | ||||
| duration | 1168.63 ± (1168.89 - 1174.84) ms | 1284.22 ± (1283.54 - 1291.30) ms | +9.9% | ❌⬆️ |
BenchmarksBenchmark execution time: 2026-08-11 17:25:28 Comparing candidate commit 19c2c9f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 72 metrics, 0 unstable metrics, 65 known flaky benchmarks, 61 flaky benchmarks without significant changes.
|
Motivation
The canonical FFE corpus requires malformed flags to be isolated from valid siblings and rejected keys to remain distinguishable from missing keys.
Changes
ea8b5cc5ce335109f11f3efbc5fd608f98a3ca54ERROR/PARSE_ERRORfor malformed flagsERROR/FLAG_NOT_FOUNDfor absent flagsDecisions
Validation
Datadog.Trace.Tests.FeatureFlags: 368/368 passed onnet10.0dotnet format --verify-no-changesgit diff --check