-
Notifications
You must be signed in to change notification settings - Fork 407
Expand file tree
/
Copy pathindex.spec.js
More file actions
511 lines (421 loc) · 15.2 KB
/
Copy pathindex.spec.js
File metadata and controls
511 lines (421 loc) · 15.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
'use strict'
const assert = require('node:assert/strict')
const { channel } = require('dc-polyfill')
const { after, afterEach, before, beforeEach, describe, it } = require('mocha')
const proxyquire = require('proxyquire')
const sinon = require('sinon')
const { DD_MAJOR } = require('../../../../version')
const { INCOMPATIBLE_INITIALIZATION } = require('../../src/llmobs/constants/text')
const LLMObsTagger = require('../../src/llmobs/tagger')
const {
PROPAGATED_TRACE_ID_KEY,
SAMPLE_RATE,
SAMPLING_DECISION,
SESSION_ID,
TRACE_ID,
} = require('../../src/llmobs/constants/tags')
const { getConfigFresh } = require('../helpers/config')
const { removeDestroyHandler } = require('./util')
const spanFinishCh = channel('dd-trace:span:finish')
const evalMetricAppendCh = channel('llmobs:eval-metric:append')
const flushCh = channel('llmobs:writers:flush')
const injectCh = channel('dd-trace:span:inject')
describe('module', () => {
let llmobsModule
let store
let logger
let LLMObsSpanWriterSpy
let LLMObsEvalMetricsWriterSpy
let fetchAgentInfoStub
/** @type {import('sinon').SinonStub} */
let startupLogStub
beforeEach(() => {
store = {}
logger = { debug: sinon.stub() }
LLMObsSpanWriterSpy = sinon.stub().returns({
destroy: sinon.stub(),
setAgentless: sinon.stub(),
})
LLMObsEvalMetricsWriterSpy = sinon.stub().returns({
destroy: sinon.stub(),
append: sinon.stub(),
setAgentless: sinon.stub(),
})
fetchAgentInfoStub = sinon.stub()
const llmobsModuleProxyRequireMeta = {
'./writers/spans': LLMObsSpanWriterSpy,
'./writers/evaluations': LLMObsEvalMetricsWriterSpy,
'../log': logger,
'./storage': {
storage: {
getStore () {
return store
},
},
},
'./writers/util': proxyquire('../../../dd-trace/src/llmobs/writers/util', {
'../../agent/info': {
fetchAgentInfo: fetchAgentInfoStub,
},
}),
}
if (DD_MAJOR < 6) {
startupLogStub = sinon.stub(console, 'error')
} else {
startupLogStub = sinon.stub()
llmobsModuleProxyRequireMeta['../startup-log'] = {
logGenericError: startupLogStub,
}
}
llmobsModule = proxyquire('../../../dd-trace/src/llmobs', llmobsModuleProxyRequireMeta)
removeDestroyHandler()
})
afterEach(() => {
sinon.restore()
llmobsModule.disable()
})
after(() => {
// get rid of mock stubs for writers
delete require.cache[require.resolve('../../../dd-trace/src/llmobs')]
})
describe('handle llmobs info injection', () => {
it('injects LLMObs info when there is a parent LLMObs span', () => {
llmobsModule.enable({ llmobs: { mlApp: 'test', agentlessEnabled: false } })
store.span = {
context () {
return {
toSpanId () {
return 'parent-id'
},
}
},
}
const carrier = {
'x-datadog-tags': '',
}
injectCh.publish({ carrier })
assert.strictEqual(carrier['x-datadog-tags'], '_dd.p.llmobs_parent_id=parent-id,_dd.p.llmobs_ml_app=test')
})
it('injects the sampling rate and decision from the parent LLMObs span', () => {
llmobsModule.enable({ llmobs: { mlApp: 'test', agentlessEnabled: false } })
store.span = {
context () {
return {
toSpanId () {
return 'parent-id'
},
}
},
}
LLMObsTagger.tagMap.set(store.span, {
[SAMPLE_RATE]: '0.5',
[SAMPLING_DECISION]: '0',
})
const carrier = {
'x-datadog-tags': '',
}
injectCh.publish({ carrier })
assert.strictEqual(
carrier['x-datadog-tags'],
'_dd.p.llmobs_parent_id=parent-id,_dd.p.llmobs_ml_app=test,_dd.p.llmobs_sr=0.5,_dd.p.llmobs_sd=0'
)
})
it('injects the session_id from the parent LLMObs span', () => {
llmobsModule.enable({ llmobs: { mlApp: 'test', agentlessEnabled: false } })
store.span = {
context () {
return {
toSpanId () {
return 'parent-id'
},
}
},
}
LLMObsTagger.tagMap.set(store.span, {
[SESSION_ID]: 'my-session',
})
const carrier = {
'x-datadog-tags': '',
}
injectCh.publish({ carrier })
assert.strictEqual(
carrier['x-datadog-tags'],
'_dd.p.llmobs_parent_id=parent-id,_dd.p.llmobs_ml_app=test,_dd.p.llmobs_sid=my-session'
)
})
it('injects the session_id from the trace-level default when the active span carries none', () => {
llmobsModule.enable({ llmobs: { mlApp: 'test', agentlessEnabled: false } })
store.span = {
context () {
return {
toSpanId () {
return 'parent-id'
},
_trace: { tags: { '_ml_obs.trace_session_id': 'trace-session' } },
}
},
}
const carrier = {
'x-datadog-tags': '',
}
injectCh.publish({ carrier })
assert.strictEqual(
carrier['x-datadog-tags'],
'_dd.p.llmobs_parent_id=parent-id,_dd.p.llmobs_ml_app=test,_dd.p.llmobs_sid=trace-session'
)
})
it('converts the local LLMObs trace id to decimal for propagation', () => {
llmobsModule.enable({ llmobs: { mlApp: 'test', agentlessEnabled: false } })
store.span = {
context () {
return {
_trace: { tags: {} },
toSpanId () { return 'parent-id' },
}
},
}
LLMObsTagger.tagMap.set(store.span, {
[TRACE_ID]: '6a5f76e7000000001973227978d8110b',
})
const carrier = { 'x-datadog-tags': '' }
injectCh.publish({ carrier })
assert.strictEqual(
carrier['x-datadog-tags'],
// eslint-disable-next-line @stylistic/max-len
'_dd.p.llmobs_parent_id=parent-id,_dd.p.llmobs_ml_app=test,_dd.p.llmobs_trace_id=141393847380800662846519802803680448779'
)
})
it('forwards an extracted LLMObs trace id without reinterpreting it', () => {
llmobsModule.enable({ llmobs: { mlApp: 'test', agentlessEnabled: false } })
const wireTraceId = '12345678901234567890123456789012'
store.span = {
context () {
return {
_trace: { tags: { [PROPAGATED_TRACE_ID_KEY]: wireTraceId } },
toSpanId () { return 'parent-id' },
}
},
}
const carrier = { 'x-datadog-tags': '' }
injectCh.publish({ carrier })
assert.strictEqual(
carrier['x-datadog-tags'],
`_dd.p.llmobs_parent_id=parent-id,_dd.p.llmobs_ml_app=test,_dd.p.llmobs_trace_id=${wireTraceId}`
)
})
it('does not inject LLMObs parent ID info when there is no parent LLMObs span', () => {
llmobsModule.enable({ llmobs: { mlApp: 'test', agentlessEnabled: false } })
const carrier = {
'x-datadog-tags': '',
}
injectCh.publish({ carrier })
assert.strictEqual(carrier['x-datadog-tags'], '_dd.p.llmobs_ml_app=test')
})
it('does not inject LLMOBs info when there is no mlApp configured and no parent LLMObs span', () => {
llmobsModule.enable({ llmobs: { agentlessEnabled: false } })
const carrier = {
'x-datadog-tags': '',
}
injectCh.publish({ carrier })
assert.strictEqual(carrier['x-datadog-tags'], '')
})
it('does not produce a literal "undefined" prefix when carrier has no x-datadog-tags', () => {
llmobsModule.enable({ llmobs: { mlApp: 'test', agentlessEnabled: false } })
const carrier = {}
injectCh.publish({ carrier })
assert.strictEqual(carrier['x-datadog-tags'], '_dd.p.llmobs_ml_app=test')
})
it('appends to an existing non-empty x-datadog-tags with a single comma separator', () => {
llmobsModule.enable({ llmobs: { mlApp: 'test', agentlessEnabled: false } })
const carrier = {
'x-datadog-tags': '_dd.p.tid=69fe014200000000,_dd.p.dm=-0',
}
injectCh.publish({ carrier })
assert.strictEqual(
carrier['x-datadog-tags'],
'_dd.p.tid=69fe014200000000,_dd.p.dm=-0,_dd.p.llmobs_ml_app=test'
)
})
it('does not duplicate _dd.p.llmobs_ml_app when already present in x-datadog-tags', () => {
llmobsModule.enable({ llmobs: { mlApp: 'test', agentlessEnabled: false } })
const carrier = {
'x-datadog-tags': '_dd.p.tid=69fe014200000000,_dd.p.dm=-0,_dd.p.llmobs_ml_app=test',
}
injectCh.publish({ carrier })
assert.strictEqual(
carrier['x-datadog-tags'],
'_dd.p.tid=69fe014200000000,_dd.p.dm=-0,_dd.p.llmobs_ml_app=test'
)
})
it('updates existing LLMObs tags in x-datadog-tags without duplicating keys', () => {
llmobsModule.enable({ llmobs: { mlApp: 'test', agentlessEnabled: false } })
store.span = {
context () {
return {
toSpanId () {
return 'new-parent-id'
},
}
},
}
LLMObsTagger.tagMap.set(store.span, {
[SESSION_ID]: 'new-session',
[SAMPLE_RATE]: '0.8',
[SAMPLING_DECISION]: '1',
})
const carrier = {
'x-datadog-tags':
'_dd.p.tid=69fe014200000000,_dd.p.llmobs_parent_id=old-id,_dd.p.llmobs_ml_app=old-app,_dd.p.llmobs_sid=old-session',
}
injectCh.publish({ carrier })
assert.strictEqual(
carrier['x-datadog-tags'],
'_dd.p.tid=69fe014200000000,_dd.p.llmobs_parent_id=new-parent-id,_dd.p.llmobs_ml_app=test,_dd.p.llmobs_sid=new-session,_dd.p.llmobs_sr=0.8,_dd.p.llmobs_sd=1'
)
})
describe('with DD_TRACE_X_DATADOG_TAGS_MAX_LENGTH=0', () => {
let config
before(() => {
process.env.DD_TRACE_X_DATADOG_TAGS_MAX_LENGTH = '0'
config = getConfigFresh({ llmobs: { mlApp: 'test', agentlessEnabled: false } })
delete process.env.DD_TRACE_X_DATADOG_TAGS_MAX_LENGTH
})
it('does not write x-datadog-tags', () => {
llmobsModule.enable(config)
const carrier = {}
injectCh.publish({ carrier })
assert.ok(!('x-datadog-tags' in carrier))
})
})
})
describe('with agentlessEnabled set to `true`', () => {
describe('when no api key is provided', () => {
it('throws an error', () => {
llmobsModule.enable({
llmobs: {
agentlessEnabled: true,
},
startupLogs: true,
})
sinon.assert.calledWith(startupLogStub, INCOMPATIBLE_INITIALIZATION)
})
})
describe('when no site is provided', () => {
it('throws an error', () => {
llmobsModule.enable({ llmobs: { agentlessEnabled: true, apiKey: 'test' }, startupLogs: true })
sinon.assert.calledWith(startupLogStub, INCOMPATIBLE_INITIALIZATION)
})
})
describe('if an api key is provided', () => {
it('configures agentless writers', () => {
llmobsModule.enable({
llmobs: {
agentlessEnabled: true,
},
DD_API_KEY: 'test',
site: 'datadoghq.com',
})
sinon.assert.calledWith(LLMObsSpanWriterSpy().setAgentless, true)
sinon.assert.calledWith(LLMObsEvalMetricsWriterSpy().setAgentless, true)
})
})
})
describe('with agentlessEnabled set to `false`', () => {
it('configures agent-proxy writers', () => {
llmobsModule.enable({
llmobs: {
agentlessEnabled: false,
},
})
sinon.assert.calledWith(LLMObsSpanWriterSpy().setAgentless, false)
sinon.assert.calledWith(LLMObsEvalMetricsWriterSpy().setAgentless, false)
})
})
describe('with agentlessEnabled set to undefined', () => {
afterEach(() => {
sinon.restore()
})
describe('when an agent is running', () => {
describe('when the agent does not have the correct proxy endpoint', () => {
beforeEach(() => {
fetchAgentInfoStub.callsFake((url, cb) => {
cb(null, {})
})
})
describe('when no API key is provided', () => {
it('throws an error', () => {
llmobsModule.enable({ llmobs: { mlApp: 'test', site: 'datadoghq.com' }, startupLogs: true })
sinon.assert.calledWith(startupLogStub, INCOMPATIBLE_INITIALIZATION)
})
})
describe('when no site is provided', () => {
it('throws an error', () => {
llmobsModule.enable({ llmobs: { mlApp: 'test', apiKey: 'test' }, startupLogs: true })
sinon.assert.calledWith(startupLogStub, INCOMPATIBLE_INITIALIZATION)
})
})
it('configures the agentless writers', () => {
llmobsModule.enable({
llmobs: {},
DD_API_KEY: 'test',
site: 'datadoghq.com',
})
sinon.assert.calledWith(LLMObsSpanWriterSpy().setAgentless, true)
sinon.assert.calledWith(LLMObsEvalMetricsWriterSpy().setAgentless, true)
})
})
describe('when the agent has the correct proxy endpoint', () => {
beforeEach(() => {
fetchAgentInfoStub.callsFake((url, cb) => {
cb(null, { endpoints: ['/evp_proxy/v2/'] })
})
})
it('configures the agent-proxy writers', () => {
llmobsModule.enable({ llmobs: { mlApp: 'test' } })
sinon.assert.calledWith(LLMObsSpanWriterSpy().setAgentless, false)
sinon.assert.calledWith(LLMObsEvalMetricsWriterSpy().setAgentless, false)
})
})
})
describe('when no agent is running', () => {
beforeEach(() => {
fetchAgentInfoStub.callsFake((url, cb) => {
cb(new Error('No agent running'))
})
})
describe('when no API key is provided', () => {
it('throws an error', () => {
llmobsModule.enable({ llmobs: { mlApp: 'test', site: 'datadoghq.com' }, startupLogs: true })
sinon.assert.calledWith(startupLogStub, INCOMPATIBLE_INITIALIZATION)
})
})
describe('when no site is provided', () => {
it('throws an error', () => {
llmobsModule.enable({ llmobs: {}, DD_API_KEY: 'test', startupLogs: true })
sinon.assert.calledWith(startupLogStub, INCOMPATIBLE_INITIALIZATION)
})
})
describe('when an API key is provided', () => {
it('configures the agentless writers', () => {
llmobsModule.enable({ llmobs: {}, DD_API_KEY: 'test', site: 'datadoghq.com' })
sinon.assert.calledWith(LLMObsSpanWriterSpy().setAgentless, true)
sinon.assert.calledWith(LLMObsEvalMetricsWriterSpy().setAgentless, true)
})
})
})
})
it('appends to the eval metric writer', () => {
llmobsModule.enable({ llmobs: { mlApp: 'test', agentlessEnabled: false } })
const payload = {}
evalMetricAppendCh.publish({ payload })
sinon.assert.calledWith(LLMObsEvalMetricsWriterSpy().append, payload, undefined)
})
it('removes all subscribers when disabling', () => {
llmobsModule.enable({ llmobs: { mlApp: 'test', agentlessEnabled: false } })
llmobsModule.disable()
assert.strictEqual(injectCh.hasSubscribers, false)
assert.strictEqual(evalMetricAppendCh.hasSubscribers, false)
assert.strictEqual(spanFinishCh.hasSubscribers, false)
assert.strictEqual(flushCh.hasSubscribers, false)
})
})