feat(profiling): pack column numbers for server-side unminification (#9501)

* feat(profiling): pack column numbers for server-side unminification

Updates profiler to 5.17.0, and then sets columnNumbers: 'pack' on the wall profiler and pass 'pack' to the space profiler's heap.profile call. pprof 5.17.0 packs the column into the line only for frames whose source map is declared but missing (dd:has-missing-map-files) — exactly the frames sent for server-side unminification — so this lets the
backend deobfuscate minified Node.js (e.g. Next.js server) frames, where the column is the only discriminator between functions on a single generated line.

Author: szegedi

package.json

@@ -179,7 +179,7 @@
     "@datadog/native-iast-taint-tracking": "4.2.0",
     "@datadog/native-metrics": "3.1.2",
     "@datadog/openfeature-node-server": "2.0.0",
-    "@datadog/pprof": "5.15.1",
+    "@datadog/pprof": "5.17.0",
     "@datadog/wasm-js-rewriter": "5.0.1",
     "@opentelemetry/api": ">=1.0.0 <1.10.0",
     "@opentelemetry/api-logs": "<1.0.0",

packages/dd-trace/src/profiling/profilers/space.js

@@ -59,7 +59,7 @@ class NativeSpaceProfiler {
   }
 
   profile (restart) {
-    const profile = this.#pprof.heap.profile(undefined, this.#mapper, getThreadLabels)
+    const profile = this.#pprof.heap.profile(undefined, this.#mapper, getThreadLabels, 'pack')
     if (!restart) {
       this.stop()
     }

packages/dd-trace/src/profiling/profilers/wall.js

@@ -187,6 +187,7 @@ class NativeWallProfiler {
 
     this.#pprof.time.start({
       collectCpuTime: this.#cpuProfilingEnabled,
+      columnNumbers: 'pack',
       durationMillis: this.#flushIntervalMillis,
       intervalMicros: this.#samplingIntervalMicros,
       lineNumbers: false,

packages/dd-trace/test/profiling/profilers/wall.spec.js

@@ -102,6 +102,7 @@ describe('profilers/native/wall', () => {
         sourceMapper: undefined,
         withContexts: false,
         lineNumbers: false,
+        columnNumbers: 'pack',
         workaroundV8Bug: false,
         collectCpuTime: false,
         useCPED: false,
@@ -121,6 +122,7 @@ describe('profilers/native/wall', () => {
         sourceMapper: undefined,
         withContexts: false,
         lineNumbers: false,
+        columnNumbers: 'pack',
         workaroundV8Bug: false,
         collectCpuTime: false,
         useCPED: false,
@@ -250,6 +252,7 @@ describe('profilers/native/wall', () => {
         sourceMapper: mapper,
         withContexts: false,
         lineNumbers: false,
+        columnNumbers: 'pack',
         workaroundV8Bug: false,
         collectCpuTime: false,
         useCPED: false,

yarn.lock

@@ -286,14 +286,14 @@
   dependencies:
     "@datadog/flagging-core" "1.2.1"
 
-"@datadog/pprof@5.15.1":
-  version "5.15.1"
-  resolved "https://registry.yarnpkg.com/@datadog/pprof/-/pprof-5.15.1.tgz#934180721351571ad75b1bce7bde406e6b519aaf"
-  integrity sha512-4mI750tX6okNROS4YKvGQjyAQ+VqfzDqzysCytOJhL2E2ktK/q4M0PtC7j70tiirGb/fO9fjma3IMNSRLYX+xQ==
+"@datadog/pprof@5.17.0":
+  version "5.17.0"
+  resolved "https://registry.yarnpkg.com/@datadog/pprof/-/pprof-5.17.0.tgz#1a40cb77243cbfccd1684c70992512f533addb67"
+  integrity sha512-BuedZ4vHzmQkitMMdIhVLQ+nPpHl7WRwcuumJeXt0ylhwGGwt7Kf+4CoS1tDB0FljJXi4izweFfFFTirrijP5w==
   dependencies:
     node-gyp-build "^4.8.4"
     pprof-format "^2.2.1"
-    source-map "^0.7.4"
+    source-map "^0.8.0"
 
 "@datadog/wasm-js-rewriter@5.0.1":
   version "5.0.1"
@@ -3854,10 +3854,10 @@ source-map@^0.6.0, source-map@^0.6.1:
   resolved "https://registry.yarnpkg.com/source-map/-/source-map-0.6.1.tgz#74722af32e9614e9c287a8d0bbde48b5e2f1a263"
   integrity sha512-UjgapumWlbMhkBgzT7Ykc5YXUT46F0iKu8SGXq0bcwP5dz/h0Plj6enJqjz1Zbq2l5WaqYnrVbwWOWMyF3F47g==
 
-source-map@^0.7.4:
-  version "0.7.6"
-  resolved "https://registry.yarnpkg.com/source-map/-/source-map-0.7.6.tgz#a3658ab87e5b6429c8a1f3ba0083d4c61ca3ef02"
-  integrity sha512-i5uvt8C3ikiWeNZSVZNWcfZPItFQOsYTUAOkcUPGd8DqDy1uOUikjt5dG+uRlwyvR108Fb9DOd4GvXfT0N2/uQ==
+source-map@^0.8.0:
+  version "0.8.0"
+  resolved "https://registry.yarnpkg.com/source-map/-/source-map-0.8.0.tgz#72b9006383bd9fc70d52e435c91c2d73249c60a4"
+  integrity sha512-d8EqvL+k/SOXCreS/SUzg2ciyHqBBLcN/yuRjFsbvVhHTE2pgei7oAhmPM7kWFbkX6OSMQfUq4KbkF3au9lhYQ==
 
 spark-md5@^3.0.2:
   version "3.0.2"