Skip to content

Commit 1e681ec

Browse files
authored
fix: do not send empty flare file to the agent (#7287)
1 parent 53eab58 commit 1e681ec

2 files changed

Lines changed: 19 additions & 1 deletion

File tree

packages/dd-trace/src/flare/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ const flare = {
6464
},
6565

6666
_sendFile (task, file, filename) {
67-
if (!file) return
67+
if (!file || file.length === 0) return
6868

6969
const form = new FormData()
7070

packages/dd-trace/test/flare.spec.js

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,4 +161,22 @@ describe('Flare', () => {
161161

162162
flare.send(task)
163163
})
164+
165+
it('should not send an empty file', done => {
166+
const timer = setTimeout(() => done(), 100)
167+
168+
handler = req => {
169+
const file = req.files[0]
170+
171+
if (file.originalname !== 'tracer_logs.txt') return
172+
173+
clearTimeout(timer)
174+
175+
done(new Error('Received empty file.'))
176+
}
177+
178+
flare.enable(tracerConfig)
179+
flare.prepare('debug')
180+
flare.send(task)
181+
})
164182
})

0 commit comments

Comments
 (0)