refactor(otlp): rely on initialized resource inputs

Author: mabdinur

packages/dd-trace/src/opentelemetry/metrics/index.js

@@ -81,7 +81,7 @@ function initializeOpenTelemetryMetrics (config) {
 }
 
 /**
- * @param {Record<string, unknown>} [tags]
+ * @param {Record<string, unknown>} tags
  * @param {object} [options]
  * @param {boolean} [options.reportHostname]
  * @param {string} [options.service]
@@ -100,20 +100,18 @@ function buildResourceAttributes (tags, { reportHostname, service, env, serviceV
   if (env) attrs['deployment.environment.name'] = env
   if (reportHostname) attrs['host.name'] = os.hostname()
 
-  if (tags?.['runtime-id']) attrs['datadog.runtime_id'] = tags['runtime-id']
-  if (tags) {
-    const tracerTags = []
-    for (const [key, value] of Object.entries(tags)) {
-      const valueType = typeof value
-      const supported = valueType === 'string' || valueType === 'boolean' ||
-        (valueType === 'number' && Number.isFinite(value))
-      if (!RESERVED_TRACER_TAGS.has(key) && supported) tracerTags.push(`${key}:${value}`)
-    }
-    if (tracerTags.length) attrs['datadog.tracer_tags'] = tracerTags
+  if (tags['runtime-id']) attrs['datadog.runtime_id'] = tags['runtime-id']
+  const tracerTags = []
+  for (const [key, value] of Object.entries(tags)) {
+    const valueType = typeof value
+    const supported = valueType === 'string' || valueType === 'boolean' ||
+      (valueType === 'number' && Number.isFinite(value))
+    if (!RESERVED_TRACER_TAGS.has(key) && supported) tracerTags.push(`${key}:${value}`)
   }
+  if (tracerTags.length) attrs['datadog.tracer_tags'] = tracerTags
   // Mirrors the legacy v0.6/stats ProcessTags shape (buildProcessTags().tagsArray); keep both in sync.
   const processTagsArray = processTags.tagsArray
-  if (processTagsArray?.length) {
+  if (processTagsArray.length) {
     attrs['datadog.process_tags'] = processTagsArray
   }
   return attrs

packages/dd-trace/test/opentelemetry/metrics/otlp_span_stats_exporter.spec.js

@@ -2,7 +2,7 @@
 
 const assert = require('node:assert/strict')
 const http = require('node:http')
-const { describe, it, beforeEach, afterEach } = require('mocha')
+const { describe, it, before, beforeEach, afterEach } = require('mocha')
 const sinon = require('sinon')
 
 require('../../setup/core')
@@ -16,6 +16,8 @@ const processTags = require('../../../src/process-tags')
 const RESOURCE_ATTRS = { 'service.name': 'svc' }
 const BUCKET_SIZE_NS = 10 * 1e9
 
+before(() => processTags.initialize())
+
 function makeSpan (overrides = {}) {
   return {
     startTime: 12345 * 1e9,
@@ -91,7 +93,6 @@ describe('buildResourceAttributes', () => {
   })
 
   it('includes datadog.process_tags as a single array attribute', () => {
-    processTags.initialize()
     const attrs = buildResourceAttributes({})
     assert.ok(Array.isArray(attrs['datadog.process_tags']))
     assert.ok(!('datadog.entrypoint.type' in attrs))
@@ -113,6 +114,7 @@ describe('createOtlpSpanStatsExporter', () => {
     const exporter = createOtlpSpanStatsExporter({
       OTEL_EXPORTER_OTLP_METRICS_ENDPOINT: 'http://localhost:4318/v1/metrics',
       service: 'svc',
+      tags: {},
     })
     assert.ok(exporter instanceof OtlpStatsExporter)
   })