Skip to content

Commit 3420490

Browse files
committed
test(llmobs): cover dataset tag filters
1 parent 6eb6d94 commit 3420490

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

packages/dd-trace/test/llmobs/experiments/index.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -274,8 +274,8 @@ describe('LLMObs Experiments facade', () => {
274274
])
275275
assert.deepEqual(dataset.recordIds(), ['r1', 'r2'])
276276
sinon.assert.calledWith(ExperimentsClient.prototype.listDatasets, 'proj', { name: 'remote-dataset' })
277-
assert.deepEqual(listDatasetRecords.firstCall.args, ['proj', 'ds', { cursor: '', version: 2 }])
278-
assert.deepEqual(listDatasetRecords.secondCall.args, ['proj', 'ds', { cursor: 'next-page', version: 2 }])
277+
assert.deepEqual(listDatasetRecords.firstCall.args, ['proj', 'ds', { cursor: '', tags: [], version: 2 }])
278+
assert.deepEqual(listDatasetRecords.secondCall.args, ['proj', 'ds', { cursor: 'next-page', tags: [], version: 2 }])
279279
})
280280

281281
it('uses the latest dataset version when no version is requested', async () => {
@@ -287,7 +287,7 @@ describe('LLMObs Experiments facade', () => {
287287
const dataset = await createExperiments(enabledConfig()).pullDataset('remote-dataset', { maxWaitMs: 0 })
288288

289289
assert.equal(dataset.version(), 5)
290-
assert.deepEqual(listDatasetRecords.firstCall.args, ['proj', 'ds', { cursor: '', version: 5 }])
290+
assert.deepEqual(listDatasetRecords.firstCall.args, ['proj', 'ds', { cursor: '', tags: [], version: 5 }])
291291
})
292292

293293
it('surfaces list failures from the backend client', async () => {

0 commit comments

Comments
 (0)