fix(openfeature): keep provider fallback opaque to webpack

Webpack parses a bare dynamic require even behind the non-webpack branch, reintroducing a critical expression-dependency warning when the peer is absent. The fallback must remain recognizable to nft without exposing that expression dependency to webpack.

Author: BridgeAR

packages/dd-trace/src/openfeature/require-provider.js

@@ -1,16 +1,18 @@
 'use strict'
 
-/**
- * @param {string} request
- * @returns {typeof import('@datadog/openfeature-node-server')}
- */
-function requireOptionalPeer (request) {
-  // @ts-expect-error webpack exposes this escape hatch as a free variable.
-  // eslint-disable-next-line camelcase, no-undef
-  if (typeof __non_webpack_require__ === 'function') return __non_webpack_require__(request)
-  // eslint-disable-next-line sonarjs/prefer-immediate-return -- nft recognizes this bound-require shape.
-  const optionalPeer = require(request)
-  return optionalPeer
+/** @type {typeof import('@datadog/openfeature-node-server')} */
+let provider
+
+// @ts-expect-error webpack exposes this escape hatch as a free variable.
+// eslint-disable-next-line camelcase
+if (typeof __non_webpack_require__ === 'function') {
+  // eslint-disable-next-line no-undef
+  provider = __non_webpack_require__('@datadog/openfeature-node-server')
+} else {
+  // nft recognizes createRequire through a binding named `module`.
+  const module = require('node:module')
+  const requireOptionalPeer = module.createRequire(__filename)
+  provider = requireOptionalPeer('@datadog/openfeature-node-server')
 }
 
-module.exports = requireOptionalPeer('@datadog/openfeature-node-server')
+module.exports = provider

packages/dd-trace/test/openfeature/flagging_provider.spec.js

@@ -1,6 +1,7 @@
 'use strict'
 
 const assert = require('node:assert/strict')
+const fs = require('node:fs')
 
 const { describe, it, beforeEach, afterEach } = require('mocha')
 const sinon = require('sinon')
@@ -267,15 +268,19 @@ describe('FlaggingProvider', () => {
       assert.strictEqual(typeof ReloadedFlaggingProvider, 'function')
     })
 
-    it('does not statically require `@datadog/openfeature-node-server`', () => {
-      const fs = require('node:fs')
+    it('keeps the provider load opaque to bundlers', () => {
       const source = fs.readFileSync(providerModulePath, 'utf8')
 
       assert.doesNotMatch(
         source,
         /require\(\s*['"]@datadog\/openfeature-node-server['"]\s*\)/,
         'a literal require would let bundlers resolve the optional peer chain at build time'
       )
+      assert.doesNotMatch(
+        source,
+        /\brequire\(\s*[^'"\s]/,
+        'a dynamic require would create a webpack expression dependency'
+      )
     })
   })
 })