ci(lint): update validation code for unicorn v68

The validation code landed after the branch's previous base, so Unicorn 68's new checks only surfaced once the branch was rebased.

Author: BridgeAR

ci/test-optimization-validation/command-output-policy.js

@@ -108,7 +108,7 @@ function assertOutputParentsUnchanged (state) {
     }
   }
 
-  const lastExisting = state.parentIdentities[state.parentIdentities.length - 1].path
+  const lastExisting = state.parentIdentities.at(-1).path
   const relative = path.relative(lastExisting, path.dirname(state.outputPath))
   let current = lastExisting
   for (const segment of relative ? relative.split(path.sep) : []) {

ci/test-optimization-validation/command-runner.js

@@ -645,7 +645,7 @@ function formatApprovalArgument (value) {
   const argument = String(value)
   if (/^[A-Za-z0-9_@%+=:,./\\-]+$/.test(argument)) return argument
   if (process.platform === 'win32') return JSON.stringify(argument)
-  return `'${argument.replaceAll('\'', String.raw`'"'"'`)}'`
+  return `'${argument.replaceAll('\'', '\'"\'"\'')}'`
 }
 
 function serializeDisplayCommand (command) {

ci/test-optimization-validation/command-suitability.js

@@ -101,6 +101,10 @@ function isProducedBySetup (framework, localPath) {
   return false
 }
 
+/**
+ * @param {{ usesShell?: boolean, argv?: string[] }} command
+ * @param {string} repositoryRoot
+ */
 function getRepositoryYarnError (command, repositoryRoot) {
   if (command.usesShell || path.basename(command.argv?.[0] || '') !== 'yarn') return
 
@@ -112,7 +116,7 @@ function getRepositoryYarnError (command, repositoryRoot) {
       .sort()
   } catch {}
   if (releases?.length > 0) {
-    const release = path.posix.join('.yarn', 'releases', releases[releases.length - 1])
+    const release = path.posix.join('.yarn', 'releases', releases.at(-1))
     return `uses bare "yarn", but this repository pins ${release}. Use the structured command ` +
       `argv [process.execPath, "${release}", ...] so validation does not depend on an ambient Yarn shim.`
   }

ci/test-optimization-validation/plan-writer.js

@@ -136,7 +136,9 @@ function formatExecutionPlan ({
       'preloads are shown as package names; the validator resolves them from the installed `dd-trace` package.',
     ''
   )
-  for (const framework of manifest.frameworks.filter(entry => entry.status === 'runnable')) {
+  for (const framework of manifest.frameworks) {
+    if (framework.status !== 'runnable') continue
+
     appendFrameworkExecutions(
       lines,
       framework,
@@ -273,7 +275,9 @@ function formatApprovalSummary ({
   }
 
   lines.push('', '## Commands', '')
-  for (const framework of manifest.frameworks.filter(entry => entry.status === 'runnable')) {
+  for (const framework of manifest.frameworks) {
+    if (framework.status !== 'runnable') continue
+
     appendApprovalSummaryFramework(lines, framework, requestedScenario, repositoryRoot)
   }
 
@@ -490,7 +494,9 @@ function getApprovalSummaryPath (out) {
  * @returns {void}
  */
 function assertPlannedExecutablesAvailable (manifest, requestedScenario) {
-  for (const framework of manifest.frameworks.filter(entry => entry.status === 'runnable')) {
+  for (const framework of manifest.frameworks) {
+    if (framework.status !== 'runnable') continue
+
     const plannedCommands = getPlannedCommands(framework, requestedScenario)
     for (const plannedCommand of plannedCommands) {
       const executable = getUnavailableExecutable(plannedCommand.command)
@@ -1016,7 +1022,9 @@ function formatFrameworkLabel (framework, repositoryRoot) {
  */
 function appendCommandIntegrity (lines, manifest, requestedScenario) {
   const executables = new Map()
-  for (const framework of manifest.frameworks.filter(entry => entry.status === 'runnable')) {
+  for (const framework of manifest.frameworks) {
+    if (framework.status !== 'runnable') continue
+
     for (const { command } of getPlannedCommands(framework, requestedScenario)) {
       const executable = getApprovedExecutable(command)
       if (executable) {

ci/test-optimization-validation/redaction.js

@@ -27,13 +27,13 @@ const EXACT_SECRET_ASSIGNMENT_NAME_SOURCE = [
   'JWT',
   'WEBHOOK(?:_URL)?',
 ].join('|')
-const SECRET_NAME_CHARS = String.raw`[A-Za-z0-9_.-]`
+const SECRET_NAME_CHARS = '[A-Za-z0-9_.-]'
 const SECRET_ASSIGNMENT_NAME_SOURCE = [
-  String.raw`(?:${EXACT_SECRET_ASSIGNMENT_NAME_SOURCE})`,
-  String.raw`[A-Za-z_]${SECRET_NAME_CHARS}*(?:${SECRET_NAME_SOURCE})${SECRET_NAME_CHARS}*`,
-  String.raw`[A-Za-z_]${SECRET_NAME_CHARS}*[-_]PASS`,
-  String.raw`[A-Za-z_]${SECRET_NAME_CHARS}*[-_]AUTH(?:ORIZATION)?`,
-  String.raw`[A-Za-z_]${SECRET_NAME_CHARS}*[-_](?:PAT|JWT|WEBHOOK(?:_URL)?)`,
+  `(?:${EXACT_SECRET_ASSIGNMENT_NAME_SOURCE})`,
+  `[A-Za-z_]${SECRET_NAME_CHARS}*(?:${SECRET_NAME_SOURCE})${SECRET_NAME_CHARS}*`,
+  `[A-Za-z_]${SECRET_NAME_CHARS}*[-_]PASS`,
+  `[A-Za-z_]${SECRET_NAME_CHARS}*[-_]AUTH(?:ORIZATION)?`,
+  `[A-Za-z_]${SECRET_NAME_CHARS}*[-_](?:PAT|JWT|WEBHOOK(?:_URL)?)`,
   'PASS',
   'AUTH',
   'AUTHORIZATION',
@@ -68,7 +68,7 @@ const SECRET_FLAG_PATTERN = new RegExp(
   'gi'
 )
 const SECRET_FLAG_NAME_PATTERN = new RegExp(
-  String.raw`^--(?:${SECRET_FLAG_SOURCE})(?:-[A-Za-z0-9]+)*$`,
+  `^--(?:${SECRET_FLAG_SOURCE})(?:-[A-Za-z0-9]+)*$`,
   'i'
 )
 const AUTH_HEADER_PATTERN = /\b(Bearer)\s+([^\s'",}\]]+)/gi
@@ -92,10 +92,10 @@ const JWT_VALUE_PATTERN = /\beyJ[A-Za-z0-9_-]{8,}\.[A-Za-z0-9_-]{8,}\.[A-Za-z0-9
 const KNOWN_TOKEN_VALUE_PATTERN =
   /\b(?:gh[pousr]_[A-Za-z0-9_]{20,}|github_pat_[A-Za-z0-9_]{20,}|glpat-[A-Za-z0-9_-]{20,}|xox[baprs]-[A-Za-z0-9-]{20,})\b/g
 const SECRET_HEADER_ENV_NAME_SOURCE = [
-  String.raw`(?:${SECRET_NAME_SOURCE}|PAT|JWT|WEBHOOK(?:_URL)?)`,
-  String.raw`[A-Za-z_]${SECRET_NAME_CHARS}*(?:${SECRET_NAME_SOURCE})${SECRET_NAME_CHARS}*`,
-  String.raw`[A-Za-z_]${SECRET_NAME_CHARS}*[-_]AUTH(?:ORIZATION)?`,
-  String.raw`[A-Za-z_]${SECRET_NAME_CHARS}*[-_](?:PAT|JWT|WEBHOOK(?:_URL)?)`,
+  `(?:${SECRET_NAME_SOURCE}|PAT|JWT|WEBHOOK(?:_URL)?)`,
+  `[A-Za-z_]${SECRET_NAME_CHARS}*(?:${SECRET_NAME_SOURCE})${SECRET_NAME_CHARS}*`,
+  `[A-Za-z_]${SECRET_NAME_CHARS}*[-_]AUTH(?:ORIZATION)?`,
+  `[A-Za-z_]${SECRET_NAME_CHARS}*[-_](?:PAT|JWT|WEBHOOK(?:_URL)?)`,
 ].join('|')
 const SECRET_HEADER_NAME_SOURCE = [
   'dd-api-key',

ci/test-optimization-validation/scenarios/ci-wiring.js

@@ -694,6 +694,10 @@ function getMonorepoFindings ({ framework, command, probe }) {
   return findings
 }
 
+/**
+ * @param {object|undefined} probe
+ * @param {string} name
+ */
 function hasProbeTool (probe, name) {
   const signals = [
     ...(probe?.wrapperSignals || []),
@@ -703,6 +707,9 @@ function hasProbeTool (probe, name) {
   return signals.some(signal => signal.name === name)
 }
 
+/**
+ * @param {Array<{ name?: string }>} signals
+ */
 function formatToolNames (signals) {
   const names = []
   const seen = new Set()
@@ -715,9 +722,12 @@ function formatToolNames (signals) {
 
   if (names.length === 0) return ''
   if (names.length === 1) return names[0]
-  return `${names.slice(0, -1).join(', ')} and ${names[names.length - 1]}`
+  return `${names.slice(0, -1).join(', ')} and ${names.at(-1)}`
 }
 
+/**
+ * @param {string|undefined} frameworkName
+ */
 function getDisplayFrameworkName (frameworkName) {
   return {
     cucumber: 'Cucumber',

packages/dd-trace/test/ci-visibility/ci-wiring.spec.js

@@ -416,6 +416,7 @@ describe('test optimization CI wiring validation', () => {
 
   it('records when NODE_OPTIONS reaches a wrapper but not the test runner', async () => {
     const out = fs.mkdtempSync(path.join(os.tmpdir(), 'dd-test-optimization-ci-wiring-'))
+    const packageManagerScript = path.join(out, 'pnpm.cjs')
     const nxScript = path.join(out, 'nx.js')
     const jestScript = path.join(out, 'jest.js')
     fs.writeFileSync(jestScript, 'console.log("1 passing")\n')
@@ -429,6 +430,11 @@ describe('test optimization CI wiring validation', () => {
       })
       process.exit(child.status)
     `)
+    fs.writeFileSync(packageManagerScript, `
+      const { spawnSync } = require('node:child_process')
+      const child = spawnSync(process.execPath, [${JSON.stringify(nxScript)}], { stdio: 'inherit' })
+      process.exit(child.status)
+    `)
 
     try {
       const result = await runCiWiring({
@@ -445,7 +451,7 @@ describe('test optimization CI wiring validation', () => {
           },
           ciWiringCommand: {
             cwd: out,
-            argv: [process.execPath, nxScript],
+            argv: [process.execPath, packageManagerScript],
           },
           preflight: {
             ran: true,
@@ -465,7 +471,11 @@ describe('test optimization CI wiring validation', () => {
       assert.strictEqual(result.evidence.initializationProbe.reachedAnyNodeProcess, true)
       assert.strictEqual(result.evidence.initializationProbe.reachedTestRunnerProcess, false)
       assert.deepStrictEqual(result.evidence.initializationProbe.wrapperSignals.map(signal => signal.name), ['nx'])
-      assert.match(result.diagnosis, /NODE_OPTIONS probe reached nx/)
+      assert.deepStrictEqual(
+        result.evidence.initializationProbe.packageManagerSignals.map(signal => signal.name),
+        ['pnpm']
+      )
+      assert.match(result.diagnosis, /NODE_OPTIONS probe reached nx and pnpm/)
       assert.match(result.diagnosis, /did not appear to reach a Jest process/)
       assert.strictEqual(result.evidence.monorepoFindings[0].id, 'nx-executor-env-forwarding')
       assert.strictEqual(result.evidence.monorepoFindings.at(-1).id, 'node-options-not-observed-in-test-runner')