Skip to content

Commit 5284a10

Browse files
committed
removed unnecesary normalization of list
1 parent f62fe6c commit 5284a10

1 file changed

Lines changed: 4 additions & 18 deletions

File tree

packages/dd-trace/src/ritm.js

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -37,21 +37,6 @@ function normalizeModuleName (name) {
3737
return builtinModules.has(stripped) ? stripped : name
3838
}
3939

40-
function normalizeModulesList (modules) {
41-
const normalized = []
42-
const seen = new Set()
43-
44-
for (const mod of modules) {
45-
const normalizedName = normalizeModuleName(mod)
46-
if (typeof normalizedName !== 'string') continue
47-
if (seen.has(normalizedName)) continue
48-
seen.add(normalizedName)
49-
normalized.push(normalizedName)
50-
}
51-
52-
return normalized
53-
}
54-
5540
/**
5641
* @overload
5742
* @param {string[]} modules list of modules to hook into
@@ -70,15 +55,15 @@ function Hook (modules, options, onrequire) {
7055
options = {}
7156
}
7257

73-
const normalizedModules = Array.isArray(modules) ? normalizeModulesList(modules) : []
7458
options ??= {}
59+
modules ??= []
7560

76-
this.modules = normalizedModules
61+
this.modules = modules
7762
this.options = options
7863
this.onrequire = onrequire
7964

8065
if (Array.isArray(modules)) {
81-
for (const mod of normalizedModules) {
66+
for (const mod of modules) {
8267
const hooks = moduleHooks[mod]
8368

8469
if (hooks) {
@@ -108,6 +93,7 @@ function Hook (modules, options, onrequire) {
10893

10994
const builtin = isBuiltinModuleName(filename)
11095
const moduleId = builtin ? normalizeModuleName(filename) : filename
96+
11197
let name, basedir, hooks
11298
// return known patched modules immediately
11399
if (cache[moduleId]) {

0 commit comments

Comments
 (0)