Skip to content

Commit 56ffcec

Browse files
committed
ci(licenses): quote the GitHub output writes
Five `>> $GITHUB_OUTPUT` redirects in this workflow were left unquoted, which shellcheck flags as SC2086 and which master already cleared everywhere else ahead of enabling the rule.
1 parent 8514d56 commit 56ffcec

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/update-3rdparty-licenses.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,20 +42,20 @@ jobs:
4242
BASE_REPO: ${{ github.repository }}
4343
run: |
4444
set -e
45-
echo "head_oid=${{ github.event.pull_request.head.sha }}" >> $GITHUB_OUTPUT
45+
echo "head_oid=${{ github.event.pull_request.head.sha }}" >> "$GITHUB_OUTPUT"
4646
4747
if git diff --ignore-space-at-eol --exit-code LICENSE-3rdparty.csv; then
4848
echo "✅ LICENSE-3rdparty.csv is already up to date"
49-
echo "needs_update=false" >> $GITHUB_OUTPUT
49+
echo "needs_update=false" >> "$GITHUB_OUTPUT"
5050
else
5151
echo "📝 LICENSE-3rdparty.csv was modified by the regen script"
52-
echo "needs_update=true" >> $GITHUB_OUTPUT
52+
echo "needs_update=true" >> "$GITHUB_OUTPUT"
5353
fi
5454
5555
if [[ "$PR_USER_TYPE" == "Bot" ]] && [[ "$PR_HEAD_REPO" == "$BASE_REPO" ]]; then
56-
echo "is_bot_same_repo=true" >> $GITHUB_OUTPUT
56+
echo "is_bot_same_repo=true" >> "$GITHUB_OUTPUT"
5757
else
58-
echo "is_bot_same_repo=false" >> $GITHUB_OUTPUT
58+
echo "is_bot_same_repo=false" >> "$GITHUB_OUTPUT"
5959
fi
6060
6161
- name: Upload updated LICENSE-3rdparty.csv

0 commit comments

Comments
 (0)