Skip to content

Commit 64e83ee

Browse files
committed
test(plugins): remove obsolete Bun dependency workarounds (#9769)
* test(plugins): remove obsolete Bun dependency workarounds Bun 1.3.14 and the current isolated installer produce valid dependency graphs for these packages without the added direct dependencies and overrides. * test(plugins): remove stale workaround assertions `test:scripts` still asserted Knex, Limitd, and AI dependency accommodations after those configurations were removed, so the release-scripts job failed.
1 parent 661d1d2 commit 64e83ee

2 files changed

Lines changed: 0 additions & 89 deletions

File tree

packages/dd-trace/test/plugins/externals.js

Lines changed: 0 additions & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,6 @@ module.exports = {
4040
{
4141
name: 'zod',
4242
versions: ['>=3.25.75'],
43-
// `ai@4.0.2` declares `zod` as an optional peer (`^3.0.0`) and
44-
// `@ai-sdk/openai@1.3.23+` declares it as a required peer. Bun's isolated
45-
// linker skips optional peers, so inject it into each ai sandbox.
46-
dep: true,
47-
// zod-to-json-schema@3.25.x requires the zod/v3 export absent from zod@3.23.x.
48-
overrides: {
49-
'zod-to-json-schema': '<3.25.0',
50-
},
5143
},
5244
],
5345
apollo: [
@@ -409,13 +401,6 @@ module.exports = {
409401
versions: ['^16.6.0'],
410402
},
411403
],
412-
// These packages pass schema objects across package boundaries; GraphQL rejects objects created by another copy.
413-
'@apollo/gateway': [
414-
{
415-
name: 'graphql',
416-
dep: true,
417-
},
418-
],
419404
'@apollo/server': [
420405
{
421406
// The shared apollo-server-* install also brings in graphql 15.x (for apollo-server v3), which may be
@@ -425,12 +410,6 @@ module.exports = {
425410
dep: true,
426411
},
427412
],
428-
'@apollo/subgraph': [
429-
{
430-
name: 'graphql',
431-
dep: true,
432-
},
433-
],
434413
grpc: [
435414
{
436415
name: '@grpc/proto-loader',
@@ -460,13 +439,6 @@ module.exports = {
460439
name: '@vscode/sqlite3',
461440
versions: ['5.1.12-vscode'],
462441
},
463-
{
464-
// Bun runs @vscode/sqlite3's node-gyp script before its package-local tar dependency is available.
465-
name: 'tar',
466-
version: '7.5.4',
467-
dep: true,
468-
forced: true,
469-
},
470442
{
471443
name: 'pg',
472444
versions: [
@@ -559,15 +531,6 @@ module.exports = {
559531
versions: ['>=3'],
560532
},
561533
],
562-
'limitd-client': [
563-
{
564-
name: 'hashlru',
565-
// limitd-protocol@2.1.1 uses an unprefixed GitHub shorthand that Bun cannot resolve.
566-
overrides: {
567-
hashlru: 'github:jfromaniello/hashlru#return_value_on_set',
568-
},
569-
},
570-
],
571534
mariadb: [
572535
{
573536
name: 'mariadb',
@@ -676,33 +639,6 @@ module.exports = {
676639
node: '>=22',
677640
},
678641
],
679-
// Every `@openai/agents*` package declares `zod` as a peer and imports it at load time. Bun's
680-
// isolated linker skips unmet peers, so each sandbox has to declare it for the store entry it
681-
// resolves to carry `zod`; without it the SDK throws `Cannot find module 'zod'` on first require.
682-
'@openai/agents': [
683-
{
684-
name: 'zod',
685-
version: '^4.0.0',
686-
dep: true,
687-
forced: true,
688-
},
689-
],
690-
'@openai/agents-core': [
691-
{
692-
name: 'zod',
693-
version: '^4.0.0',
694-
dep: true,
695-
forced: true,
696-
},
697-
],
698-
'@openai/agents-openai': [
699-
{
700-
name: 'zod',
701-
version: '^4.0.0',
702-
dep: true,
703-
forced: true,
704-
},
705-
],
706642
passport: [
707643
{
708644
name: 'express',

scripts/test/install-plugin-modules.spec.js

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -212,13 +212,6 @@ externals.express.push({ name: 'axios', overrides: ${override} })
212212
assert.strictEqual(manifest.dependencies.bluebird, '3.7.2')
213213
})
214214

215-
it('makes the sqlite build dependency direct in knex sandboxes', () => {
216-
runInstall('knex')
217-
218-
const manifest = require(path.join(versionsDir, 'knex@1', 'package.json'))
219-
assert.strictEqual(manifest.dependencies.tar, '7.5.4')
220-
})
221-
222215
it('pins the Claude Agent SDK to its compatible zod major', () => {
223216
runInstall('claude-agent-sdk')
224217

@@ -255,13 +248,6 @@ path.join = function join (...parts) {
255248
assert.ok(readVersionsManifest().trustedDependencies.includes('libpq'))
256249
})
257250

258-
it('normalizes unprefixed GitHub shorthand dependencies for Bun', () => {
259-
runInstall('limitd-client')
260-
261-
const manifest = readVersionsManifest()
262-
assert.strictEqual(manifest.overrides.hashlru, 'github:jfromaniello/hashlru#return_value_on_set')
263-
})
264-
265251
it('scopes the q transitive override to q sandboxes', () => {
266252
runInstall('q')
267253

@@ -271,17 +257,6 @@ path.join = function join (...parts) {
271257
require(path.join(versionsDir, 'q')).get()
272258
})
273259

274-
it('scopes the ai dependency repairs to ai sandboxes', () => {
275-
runInstall('ai')
276-
277-
assert.deepStrictEqual(readVersionsManifest().overrides, {
278-
'zod-to-json-schema': '<3.25.0',
279-
})
280-
const manifest = require(path.join(versionsDir, 'ai', 'package.json'))
281-
assert.strictEqual(semver.subset(manifest.dependencies.zod, '^3.0.0'), true)
282-
require(path.join(versionsDir, 'ai@4.0.2')).get()
283-
})
284-
285260
it('scopes the recorded OpenAI dependency graph to langchain sandboxes', () => {
286261
runInstall('langchain')
287262

0 commit comments

Comments
 (0)