Commit 956052e
committed
fix(native-spans): keep OTLP export when a custom lookup is configured
The custom-`lookup` guard did not exclude OTLP, so
`OTEL_TRACES_EXPORTER=otlp` plus a configured `lookup` selected the JS
pipeline, which builds an `AgentExporter`. The OTLP endpoint was never
configured and every span went to the Datadog agent instead of the
collector.
OTLP export lives in libdatadog, so the JS pipeline cannot do it at all.
Give OTLP precedence, exactly as the Lambda pipeline already does, and
warn that the `lookup` cannot be honoured rather than dropping it in
silence.
Reported by Codex review as P1, against the commit that added the guard.1 parent 3786df7 commit 956052e
2 files changed
Lines changed: 37 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
124 | 131 | | |
125 | | - | |
126 | | - | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
127 | 137 | | |
128 | | - | |
| 138 | + | |
| 139 | + | |
129 | 140 | | |
130 | 141 | | |
131 | 142 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
376 | 376 | | |
377 | 377 | | |
378 | 378 | | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
379 | 402 | | |
380 | 403 | | |
381 | 404 | | |
| |||
0 commit comments