chore(eslint): refine unicorn rule selection

Keep negated array predicates disabled because the inverted forms obscure existing preconditions. Preserve explicit string coercion only where values are not guaranteed to be strings.

Author: BridgeAR

ci/diagnose.js

@@ -1394,7 +1394,7 @@ function findScriptMatches (scripts, patterns) {
 
   for (const script of scripts) {
     if (!/test|spec|e2e|integration|unit/i.test(script.name) &&
-      patterns.every(pattern => !pattern.test(script.command))) {
+      !patterns.some(pattern => pattern.test(script.command))) {
       continue
     }
 

ci/test-optimization-validation/cli.js

@@ -546,7 +546,7 @@ function getValidationCoverage ({ results, requestedScenario, frameworks, scenar
   if (runnableFrameworks.length === 0) return 'partial'
   for (const framework of runnableFrameworks) {
     for (const scenario of scenarios) {
-      if (results.every(result => !(result.frameworkId === framework.id && result.scenario === scenario))) {
+      if (!results.some(result => result.frameworkId === framework.id && result.scenario === scenario)) {
         return 'partial'
       }
     }

ci/test-optimization-validation/command-runner.js

@@ -215,12 +215,12 @@ function runCommand (command, options = {}) {
     child.stdout.on('data', chunk => {
       const capture = appendCapturedOutput(result.stdout, chunk, maxOutputBytes)
       result.stdout = capture.output
-      result.stdoutTruncated = result.stdoutTruncated || capture.truncated
+      result.stdoutTruncated ||= capture.truncated
     })
     child.stderr.on('data', chunk => {
       const capture = appendCapturedOutput(result.stderr, chunk, maxOutputBytes)
       result.stderr = capture.output
-      result.stderrTruncated = result.stderrTruncated || capture.truncated
+      result.stderrTruncated ||= capture.truncated
     })
     child.on('error', err => {
       result.stderr += `${err.stack || err}\n`

ci/test-optimization-validation/command-suitability.js

@@ -183,7 +183,7 @@ function getVitestGeneratedPathError (command, framework, repositoryRoot) {
     const relative = path.relative(path.dirname(configFile), file.path).split(path.sep).join('/')
     if (relative === '..' || relative.startsWith('../') || path.isAbsolute(relative)) continue
 
-    if (includes.length > 0 && includes.every(pattern => !matchesGlob(relative, pattern))) {
+    if (includes.length > 0 && !includes.some(pattern => matchesGlob(relative, pattern))) {
       return `uses temporary test path ${file.path}, which does not match the literal test.include patterns in ` +
         `${configFile}: ${includes.join(', ')}. Choose a temporary test path accepted by the selected Vitest ` +
         'config ' +

ci/test-optimization-validation/plan-writer.js

@@ -406,7 +406,7 @@ function appendApprovalSummaryFramework (lines, framework, requestedScenario, re
     lines.push('**Temporary test source:**', '')
     for (const file of strategy.files || []) {
       lines.push(
-        `${inlineCode(getRepositoryRelativePath(repositoryRoot, file.path))}`,
+        inlineCode(getRepositoryRelativePath(repositoryRoot, file.path)),
         '',
         codeBlock(file.contentLines.join('\n')),
         ''

ci/test-optimization-validation/report-writer.js

@@ -845,7 +845,7 @@ function getResultDetailLines (result, options = {}) {
 
 function getCommonArtifactDirectory (artifacts) {
   let directory = path.dirname(path.resolve(artifacts[0]))
-  while (artifacts.some(artifact => !isPathInside(directory, path.resolve(artifact)))) {
+  while (!artifacts.every(artifact => isPathInside(directory, path.resolve(artifact)))) {
     const parent = path.dirname(directory)
     if (parent === directory) return directory
     directory = parent

ci/test-optimization-validation/scenarios/ci-wiring.js

@@ -338,7 +338,7 @@ function getNodeOptionsRemovalDiagnosis ({ basicResult, evidence, framework }) {
     : ''
 
   return 'The CI test command ran tests, but no Test Optimization events reached the offline event artifact. ' +
-    `${ciCommand}` +
+    ciCommand +
     `${source} expands to \`${finding.command}\`. The empty \`NODE_OPTIONS=\` assignment clears the Datadog ` +
     `preload before ${frameworkName} starts.${directResult}`
 }

ci/test-optimization-validation/scenarios/test-management.js

@@ -148,7 +148,7 @@ function buildQuarantinedResponse (framework, scenario, discoveredIdentities = [
   for (const identity of identities) {
     for (const suite of getSuiteCandidates(identity, scenario)) {
       for (const name of getNameCandidates(identity)) {
-        suites[suite] = suites[suite] || { tests: {} }
+        suites[suite] ||= { tests: {} }
         suites[suite].tests[name] = {
           properties: {
             quarantined: true,

eslint.config.mjs

@@ -651,6 +651,7 @@ export default [
       'unicorn/no-array-splice': 'off', // toSpliced copies the whole array (perf)
       'unicorn/no-break-in-nested-loop': 'off', // Conflicts with our performance-oriented loops
       'unicorn/no-global-object-property-assignment': 'off', // We use globalThis[Symbol.for('dd-trace')]
+      'unicorn/no-negated-array-predicate': 'off', // Predicate inversion is harder to read and creates churn
       'unicorn/no-nested-ternary': 'off', // Not really an issue in the code and the benefit is small
       'unicorn/no-new-array': 'off', // new Array is often used for performance reasons
       'unicorn/no-null': 'off', // We do not control external APIs and it is hard to differentiate these
@@ -678,17 +679,12 @@ export default [
       'unicorn/switch-case-braces': 'off', // Questionable benefit
 
       // These remaining rules need focused rewrites before activation (counts from the v72 run).
-      'unicorn/logical-assignment-operators': 'off', // 51 errors | matches our ??=/||= usage
       'unicorn/no-confusing-array-splice': 'off', // 1 error
       'unicorn/no-for-each': 'off', // 10 errors | we already prefer for-of in production
       'unicorn/no-negated-comparison': 'off', // 1 error
       'unicorn/no-subtraction-comparison': 'off', // 2 errors
       'unicorn/no-unnecessary-global-this': 'off', // 3 errors | explicit globals are clearer
-      'unicorn/no-unnecessary-splice': 'off', // 2 errors
-      'unicorn/no-useless-concat': 'off', // 4 errors
       'unicorn/no-useless-continue': 'off', // 1 error
-      'unicorn/no-useless-delete-check': 'off', // 1 error
-      'unicorn/no-useless-template-literals': 'off', // 16 errors | String() rewrites reduce readability
       'unicorn/prefer-array-from-map': 'off', // 9 errors | loops avoid callback allocation
       'unicorn/prefer-continue': 'off', // 52 errors
       'unicorn/prefer-logical-operator-over-ternary': 'off', // 3 errors

packages/datadog-esbuild/index.js

@@ -268,7 +268,7 @@ ${build.initialOptions.banner.js}`
       let pathToPackageJson
       try {
         // we can't use require.resolve('pkg/package.json') as ESM modules don't make the file available
-        pathToPackageJson = require.resolve(`${extracted.pkg}`, { paths: [args.resolveDir] })
+        pathToPackageJson = require.resolve(extracted.pkg, { paths: [args.resolveDir] })
         pathToPackageJson = extractPackageAndModulePath(pathToPackageJson).pkgJson
       } catch (err) {
         if (err.code === 'MODULE_NOT_FOUND') {