Skip to content

Commit b30f9d7

Browse files
committed
fix(llmobs): avoid stale version on latest dataset pulls
1 parent f916375 commit b30f9d7

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

packages/dd-trace/src/llmobs/experiments/index.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,8 @@ class Experiments {
9898
if (dataset.name() === name) {
9999
pulledDataset = dataset
100100
latestVersion = dataset.latestVersion()
101-
datasetVersion = version ?? latestVersion
101+
// Let an unversioned records request resolve the latest snapshot. Dataset metadata can lag record
102+
// ingestion.
102103
break
103104
}
104105
}
@@ -158,7 +159,7 @@ class Experiments {
158159
pulledDataset.id(),
159160
projectId,
160161
records,
161-
datasetVersion,
162+
datasetVersion ?? latestVersion,
162163
latestVersion,
163164
filterTags
164165
)

packages/dd-trace/test/llmobs/experiments/index.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ describe('LLMObs Experiments facade', () => {
300300
assert.deepEqual(listDatasetRecords.secondCall.args, ['proj', 'ds', { cursor: 'next-page', tags: [], version: 2 }])
301301
})
302302

303-
it('uses the latest dataset version when no version is requested', async () => {
303+
it('uses the latest records when no version is requested', async () => {
304304
const { listDatasetRecords } = stubPullDatasetClient({
305305
datasets: [datasetResource({ name: 'remote-dataset', latestVersion: 5 })],
306306
pages: [{ records: [], after: '' }],
@@ -309,7 +309,7 @@ describe('LLMObs Experiments facade', () => {
309309
const dataset = await createExperiments(enabledConfig()).pullDataset('remote-dataset', { maxWaitMs: 0 })
310310

311311
assert.equal(dataset.version(), 5)
312-
assert.deepEqual(listDatasetRecords.firstCall.args, ['proj', 'ds', { cursor: '', tags: [], version: 5 }])
312+
assert.deepEqual(listDatasetRecords.firstCall.args, ['proj', 'ds', { cursor: '', tags: [], version: null }])
313313
})
314314

315315
it('surfaces list failures from the backend client', async () => {

0 commit comments

Comments
 (0)