[test optimization] Fix mocha test management logic (#7242)

Author: juan-fernandez

integration-tests/mocha/mocha.spec.js

@@ -4038,6 +4038,87 @@ describe(`mocha@${MOCHA_VERSION}`, function () {
       ])
       assert.match(testOutput, /Test management tests could not be fetched/)
     })
+
+    onlyLatestIt(
+      'works in parallel mode with test management enabled but ITR and suite skipping disabled',
+      async () => {
+        // This test reproduces the bug from issue #7222 where a missing 'else' keyword
+        // caused onFinishRequest() to be called twice when test management is enabled
+        // but ITR and suite skipping are disabled, resulting in the error:
+        // "invalid state transition: RUNNING => RUNNING"
+        let testOutput = ''
+        receiver.setSettings({
+          test_management: { enabled: true },
+          itr_enabled: false,
+          code_coverage: false,
+          tests_skipping: false,
+          flaky_test_retries_enabled: false,
+          known_tests_enabled: true
+        })
+        receiver.setTestManagementTests({
+          mocha: {
+            suites: {}
+          }
+        })
+
+        const eventsPromise = receiver
+          .gatherPayloadsMaxTimeout(({ url }) => url.endsWith('/api/v2/citestcycle'), (payloads) => {
+            const events = payloads.flatMap(({ payload }) => payload.events)
+            const testSession = events.find(event => event.type === 'test_session_end').content
+            assert.strictEqual(testSession.meta[TEST_MANAGEMENT_ENABLED], 'true')
+            assert.strictEqual(testSession.meta[MOCHA_IS_PARALLEL], 'true')
+            const tests = events.filter(event => event.type === 'test').map(event => event.content)
+            assert.ok(tests.length > 0)
+            const suiteEvents = events.filter(event => event.type === 'test_suite_end')
+            assert.strictEqual(suiteEvents.length, 2, 'Expected exactly 2 suites to be reported')
+            // Verify that tests have different runtime IDs, confirming parallel execution in different processes
+            // Group tests by their suite to get one test from each worker
+            const testsBySuite = {}
+            for (const test of tests) {
+              const suiteName = test.meta[TEST_SUITE]
+              if (!testsBySuite[suiteName]) {
+                testsBySuite[suiteName] = test
+              }
+            }
+            const testFromEachWorker = Object.values(testsBySuite)
+            assert.strictEqual(testFromEachWorker.length, 2, 'Expected tests from 2 different suites')
+            const testRuntimeIds = testFromEachWorker.map(test => test.meta['runtime-id'])
+            assert.ok(testRuntimeIds[0], 'First test should have a runtime-id')
+            assert.ok(testRuntimeIds[1], 'Second test should have a runtime-id')
+            // This checks that the two tests come from different workers/processes
+            assert.notStrictEqual(
+              testRuntimeIds[0],
+              testRuntimeIds[1],
+              'Tests from different workers should have different runtime-ids'
+            )
+          })
+
+        childProcess = exec(
+          'node node_modules/mocha/bin/mocha --parallel --jobs 2 ./ci-visibility/test/ci-visibility-test*',
+          {
+            cwd,
+            env: getCiVisAgentlessConfig(receiver.port),
+            stdio: 'inherit'
+          }
+        )
+
+        childProcess.stdout.on('data', (chunk) => {
+          testOutput += chunk.toString()
+        })
+        childProcess.stderr.on('data', (chunk) => {
+          testOutput += chunk.toString()
+        })
+
+        await Promise.all([
+          once(childProcess, 'exit'),
+          once(childProcess.stdout, 'end'),
+          once(childProcess.stderr, 'end'),
+          eventsPromise
+        ])
+
+        // Verify no "invalid state transition" error occurred
+        assert.doesNotMatch(testOutput, /invalid state transition/)
+      })
   })
 
   context('libraries capabilities', () => {

packages/datadog-instrumentations/src/mocha/main.js

@@ -282,7 +282,7 @@ function getExecutionConfiguration (runner, isParallel, frameworkVersion, onFini
     if (config.isTestManagementTestsEnabled) {
       ctx.onDone = onReceivedTestManagementTests
       testManagementTestsCh.runStores(ctx, () => {})
-    } if (config.isImpactedTestsEnabled) {
+    } else if (config.isImpactedTestsEnabled) {
       ctx.onDone = onReceivedImpactedTests
       modifiedFilesCh.runStores(ctx, () => {})
     } else if (config.isSuitesSkippingEnabled) {