chore(eslint): update eslint-plugin-n and callback names (#9694)

Author: BridgeAR

packages/datadog-instrumentations/test/openai-lifecycle.spec.js

@@ -101,8 +101,8 @@ function loadOpenAIInstrumentation () {
 
   const stub = {
     ...realInstrument,
-    addHook (spec, cb) {
-      hookCallbacks.push({ spec, cb })
+    addHook (spec, hook) {
+      hookCallbacks.push({ spec, hook })
     },
   }
 
@@ -121,9 +121,9 @@ function loadOpenAIInstrumentation () {
 }
 
 function applyShim (hookCallbacks, filePath, targetClass, TargetClass) {
-  for (const { spec, cb } of hookCallbacks) {
+  for (const { spec, hook } of hookCallbacks) {
     if (spec.file === `${filePath}.js`) {
-      cb({ [targetClass]: TargetClass })
+      hook({ [targetClass]: TargetClass })
       return
     }
   }

packages/datadog-plugin-grpc/test/server.spec.js

@@ -318,12 +318,12 @@ describe('Plugin', () => {
 
         it('should handle custom errors', async () => {
           const client = await buildClient({
-            getUnary: (_, callback) => {
+            getUnary: (_, respond) => {
               const metadata = new grpc.Metadata()
 
               metadata.set('extra', 'information')
 
-              callback({ message: 'foobar', code: grpc.status.NOT_FOUND }, {}, metadata)
+              respond({ message: 'foobar', code: grpc.status.NOT_FOUND }, {}, metadata)
             },
           })
 

packages/dd-trace/test/opentelemetry/logs.spec.js

@@ -72,7 +72,7 @@ describe('OpenTelemetry Logs', () => {
     let capturedPayload, capturedHeaders
     let validatorCalled = false
 
-    sinon.stub(http, 'request').callsFake((options, callback) => {
+    sinon.stub(http, 'request').callsFake((options, onResponse) => {
       // Only intercept OTLP logs requests
       if (options.path && options.path.includes('/v1/logs')) {
         capturedHeaders = options.headers
@@ -94,7 +94,7 @@ describe('OpenTelemetry Logs', () => {
           once: () => {},
           setTimeout: () => {},
         }
-        callback({ statusCode: 200, on: () => {}, once: () => {}, setTimeout: () => {} })
+        onResponse({ statusCode: 200, on: () => {}, once: () => {}, setTimeout: () => {} })
         return mockReq
       }
 
@@ -106,7 +106,7 @@ describe('OpenTelemetry Logs', () => {
         once: () => {},
         setTimeout: () => {},
       }
-      callback({ statusCode: 200, on: () => {}, once: () => {}, setTimeout: () => {} })
+      onResponse({ statusCode: 200, on: () => {}, once: () => {}, setTimeout: () => {} })
       return mockReq
     })
 

packages/dd-trace/test/opentelemetry/traces.spec.js

@@ -63,7 +63,7 @@ describe('OpenTelemetry Traces', () => {
     let capturedPayload, capturedHeaders
     let validatorCalled = false
 
-    sinon.stub(http, 'request').callsFake((options, callback) => {
+    sinon.stub(http, 'request').callsFake((options, onResponse) => {
       if (options.path && options.path.includes('/v1/traces')) {
         capturedHeaders = options.headers
         const mockReq = {
@@ -77,7 +77,7 @@ describe('OpenTelemetry Traces', () => {
           once: () => {},
           setTimeout: () => {},
         }
-        callback({ statusCode: 200, on: () => {}, once: () => {}, setTimeout: () => {} })
+        onResponse({ statusCode: 200, on: () => {}, once: () => {}, setTimeout: () => {} })
         return mockReq
       }
       const mockReq = {
@@ -87,7 +87,7 @@ describe('OpenTelemetry Traces', () => {
         once: () => {},
         setTimeout: () => {},
       }
-      callback({ statusCode: 200, on: () => {}, once: () => {}, setTimeout: () => {} })
+      onResponse({ statusCode: 200, on: () => {}, once: () => {}, setTimeout: () => {} })
       return mockReq
     })
 

packages/dd-trace/test/runtime_metrics.spec.js

@@ -1090,12 +1090,12 @@ function loadOtlpRuntimeMetricsTestModule (overrides = {}) {
     createObservableUpDownCounter: makeFactory('updowncounter'),
     createObservableCounter: makeFactory('observable-counter'),
     createHistogram: makeFactory('histogram'),
-    addBatchObservableCallback (cb, observables) {
-      batchCallbacks.push({ cb, observables })
+    addBatchObservableCallback (observeBatch, observables) {
+      batchCallbacks.push({ observeBatch, observables })
     },
-    removeBatchObservableCallback (cb) {
-      const idx = batchCallbacks.findIndex(r => r.cb === cb)
-      if (idx !== -1) batchCallbacks.splice(idx, 1)
+    removeBatchObservableCallback (observeBatch) {
+      const index = batchCallbacks.findIndex(registration => registration.observeBatch === observeBatch)
+      if (index !== -1) batchCallbacks.splice(index, 1)
     },
   }
 
@@ -1129,9 +1129,9 @@ function loadOtlpRuntimeMetricsTestModule (overrides = {}) {
 
   function fireBatchCallbacks () {
     const observed = new Map()
-    for (const { cb, observables } of batchCallbacks) {
+    for (const { observeBatch, observables } of batchCallbacks) {
       const allowed = new Set(observables)
-      cb({
+      observeBatch({
         observe: (instrument, value, attrs = {}) => {
           if (!allowed.has(instrument)) return
           if (!observed.has(instrument)) observed.set(instrument, [])