fix(exporters): isolate per-request connection agents

Author: leoromanovsky

packages/dd-trace/src/exporters/common/request.js

@@ -93,7 +93,10 @@ function request (data, options, callback) {
 
   docker.inject(options.headers)
 
-  options.agent ??= isSecure ? httpsAgent : httpAgent
+  const connectionOptions = {
+    ...options,
+    agent: options.agent ?? (isSecure ? httpsAgent : httpAgent),
+  }
 
   /**
    * @param {import('node:http').IncomingMessage} res
@@ -218,7 +221,7 @@ function request (data, options, callback) {
         }
       }
 
-      const req = client.request(options, (res) => onResponse(res, complete, handleError))
+      const req = client.request(connectionOptions, (res) => onResponse(res, complete, handleError))
 
       req.once('close', finalize)
       req.once('timeout', finalize)

packages/dd-trace/test/exporters/common/request.spec.js

@@ -133,6 +133,28 @@ describe('request', function () {
     })
   })
 
+  it('selects a new default agent when callers reuse options with another protocol', (done) => {
+    const options = {
+      url: new URL('http://test:123'),
+      path: '/path',
+      method: 'GET',
+    }
+    nock('http://test:123').get('/path').reply(200, 'OK')
+
+    request(Buffer.from(''), options, (httpError) => {
+      if (httpError) return done(httpError)
+
+      assert.strictEqual(options.agent, undefined)
+      options.url = new URL('https://test:443')
+      nock('https://test:443').get('/path').reply(200, 'OK')
+
+      request(Buffer.from(''), options, (httpsError) => {
+        assert.strictEqual(options.agent, undefined)
+        done(httpsError)
+      })
+    })
+  })
+
   it('does not retry when retries are disabled', (done) => {
     maxAttempts = 5
     const error = Object.assign(new Error('ECONNRESET'), { code: 'ECONNRESET' })