Skip to content

Commit d4f8543

Browse files
committed
chore(eslint): resolve rebase lint violations
## Summary Resolve lint violations exposed by master code after rebasing. ## Why The enabled lint rules must also validate code introduced by the updated base.
1 parent e6bbb47 commit d4f8543

3 files changed

Lines changed: 8 additions & 9 deletions

File tree

integration-tests/jest/jest.test-management.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2823,7 +2823,7 @@ describe(`jest@${JEST_VERSION} commonJS`, () => {
28232823
})
28242824

28252825
/**
2826-
* @param {Mocha.Done} done
2826+
* @param {(error?: Error) => void} done
28272827
* @param {object} options
28282828
* @param {boolean} options.isModified
28292829
* @param {boolean} [options.isEfd]

packages/datadog-instrumentations/src/jest.js

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2254,16 +2254,15 @@ function getWrappedEnvironment (BaseEnvironment, jestVersion) {
22542254
this.#efdRetryGatesByName = undefined
22552255
this.#detachedEfdRetryQueue = undefined
22562256
testSuiteDatadogEnvironments.delete(this.testSuiteAbsolutePath)
2257-
}
2258-
if (event.name === 'test_skip' || event.name === 'test_todo') {
2257+
} else if (event.name === 'test_skip' || event.name === 'test_todo') {
22592258
const testName = getJestTestName(event.test)
22602259
const retryGates = this.#efdRetryGatesByName?.get(testName)
2261-
if (retryGates && efdRetryMetadataByTest.has(event.test)) {
2262-
this.#discardedEfdRetryTests ??= new Set()
2263-
this.#discardedEfdRetryTests.add(event.test)
2264-
return
2265-
}
22662260
if (retryGates) {
2261+
if (efdRetryMetadataByTest.has(event.test)) {
2262+
this.#discardedEfdRetryTests ??= new Set()
2263+
this.#discardedEfdRetryTests.add(event.test)
2264+
return
2265+
}
22672266
for (const gate of retryGates) {
22682267
gate.resolve(false)
22692268
}

packages/dd-trace/src/ci-visibility/efd-retry-policy.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ const EARLY_FLAKE_DETECTION_RETRY_BUCKETS =
1919

2020
/**
2121
* @typedef {object} EfdRetryPolicy
22-
* @property {ReadonlyArray<EfdDurationRetryCount>} durationRetryCounts
22+
* @property {readonly EfdDurationRetryCount[]} durationRetryCounts
2323
* @property {number} schedulingRetryCount
2424
*/
2525

0 commit comments

Comments
 (0)