Skip to content

Commit e3f8e89

Browse files
committed
feat(llmobs): include dataset version in experiments
1 parent f6ffbcd commit e3f8e89

2 files changed

Lines changed: 16 additions & 2 deletions

File tree

packages/dd-trace/src/llmobs/experiments/experiment.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,8 @@ class Experiment {
149149
description: this.#description,
150150
ensure_unique: true,
151151
}
152+
const datasetVersion = this.#dataset.version()
153+
if (datasetVersion !== null) attributes.dataset_version = datasetVersion
152154
if (Object.keys(this.#config).length > 0) attributes.config = this.#config
153155

154156
let created

packages/dd-trace/test/llmobs/experiments/experiment.spec.js

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -239,8 +239,19 @@ describe('LLMObs Experiments — dataset + experiment run', () => {
239239
assert.equal(patch.body.data.attributes.error, undefined)
240240
})
241241

242-
it('experiment create body carries project_id, dataset_id, config and ensure_unique', async () => {
243-
const dataset = new Dataset(client, 'demo').addRecord('x')
242+
it('experiment create body carries project_id, dataset_id, dataset_version, config and ensure_unique', async () => {
243+
const { DatasetRecord } = require('../../../src/llmobs/experiments/dataset')
244+
const dataset = Dataset.fromExisting(
245+
client,
246+
'demo',
247+
'desc',
248+
'ds',
249+
'proj',
250+
[new DatasetRecord('x')],
251+
['rec-0'],
252+
3,
253+
7
254+
)
244255
await new Experiment(client, {
245256
name: 'exp-demo', dataset, task: (i) => i, config: { approach: 'kw' },
246257
}).run()
@@ -251,6 +262,7 @@ describe('LLMObs Experiments — dataset + experiment run', () => {
251262
assert.equal(create.body.data.type, 'experiments')
252263
assert.equal(create.body.data.attributes.project_id, 'proj')
253264
assert.equal(create.body.data.attributes.dataset_id, 'ds')
265+
assert.equal(create.body.data.attributes.dataset_version, 3)
254266
assert.equal(create.body.data.attributes.ensure_unique, true)
255267
assert.deepEqual(create.body.data.attributes.config, { approach: 'kw' })
256268
})

0 commit comments

Comments
 (0)