Skip to content

Commit e654270

Browse files
committed
On advice from crashtracking team, completing this TODO.
1 parent 56bc9d2 commit e654270

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

packages/dd-trace/src/crashtracking/crashtracker.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,12 @@ class Crashtracker {
5252
#getConfig (config) {
5353
const url = getAgentUrl(config)
5454

55+
// Out-of-process symbolication currently (crashtracker 27.0.0) works on
56+
// Linux only, does not work on Mac.
57+
const resolveMode = require('os').platform === 'linux'
58+
? 'EnabledWithSymbolsInReceiver'
59+
: 'EnabledWithInprocessSymbols'
60+
5561
return {
5662
additional_files: [],
5763
create_alt_stack: true,
@@ -70,8 +76,7 @@ class Crashtracker {
7076
timeout: { secs: 5, nanos: 0 },
7177
demangle_names: false,
7278
signals: [],
73-
// TODO: Use `EnabledWithSymbolsInReceiver` instead for Linux when fixed.
74-
resolve_frames: 'EnabledWithInprocessSymbols',
79+
resolve_frames: resolveMode,
7580
}
7681
}
7782

0 commit comments

Comments
 (0)