Commit fc23ba0
committed
fix(types): import opentracing from the consumer's installed package
`opentracing.initGlobalTracer(tracer)` fails to type-check because dd-trace's
public types reach into `./vendor/dist/opentracing` while consumers reach into
their own `node_modules/opentracing`. `Reference` / `Tracer` / `Span` declare
`protected` members, so the two copies are nominally distinct classes and the
dd-trace `Tracer` is not a subtype of the consumer's `opentracing.Tracer`.
`index.d.ts` imports from `"opentracing"` directly and the package becomes a
regular runtime dependency. npm, yarn, and pnpm hoist a single copy that both
dd-trace and the consumer resolve to, and TypeScript dedupes the nominal
class identity by `name@version` Package ID, so `initGlobalTracer(tracer)`
accepts dd-trace's `Tracer`. The range is `>=0.14.0` rather than `>=0.14.7`
to widen the hoist window for consumers pinned to an older patch — the
repository was archived on 2023-05-23 and the type surface is identical
across 0.14.0–0.14.7.
The vendored type copy and its rspack build step are dropped; dd-trace's
runtime never required the package.
Fixes: #8523
Refs: #69581 parent 806f177 commit fc23ba0
10 files changed
Lines changed: 8 additions & 27 deletions
File tree
- docs
- packages/dd-trace/test
- opentracing
- vendor
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
161 | 161 | | |
162 | 162 | | |
163 | 163 | | |
164 | | - | |
| 164 | + | |
| 165 | + | |
165 | 166 | | |
166 | 167 | | |
167 | 168 | | |
| |||
218 | 219 | | |
219 | 220 | | |
220 | 221 | | |
221 | | - | |
222 | 222 | | |
223 | 223 | | |
224 | 224 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | 25 | | |
27 | 26 | | |
28 | 27 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | 83 | | |
91 | 84 | | |
92 | 85 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3435 | 3435 | | |
3436 | 3436 | | |
3437 | 3437 | | |
3438 | | - | |
| 3438 | + | |
3439 | 3439 | | |
3440 | 3440 | | |
3441 | 3441 | | |
| |||
0 commit comments