Commit 5fe261d
authored
test(appsec): isolate filesystem and browser side effects (#19693)
## Description
IAST and AppSec test runs could leave filesystem artifacts in the checkout and launch the host browser.
- Run path-traversal rename, copy, and move destinations in automatically cleaned temporary directories.
- Run Django AppSec tests against a worker-local temporary copy of the checked-in SQLite template.
- Configure the default browser for the IAST Riot environment as the no-op `true` command.
This keeps the checkout clean while preserving the sink calls exercised by IAST.
## Testing
- `scripts/lint checks`
- `scripts/lint riot`
- Focused IAST path-traversal and browser tests: 34 passed
- IAST webbrowser tests under the rebuilt Riot environment: 2 passed
- Django automatic user-event tests: 72 passed
- Verified `tests/appsec/contrib_appsec/db.sqlite3` still matches its `HEAD` blob after the ORM tests
## Risks
Low. The changes are limited to test fixtures and test-environment configuration.
## Additional Notes
No release note is needed because this is a test-only change.
Co-authored-by: florentin.labelle <florentin.labelle@datadoghq.com>1 parent a24b7b3 commit 5fe261d
3 files changed
Lines changed: 35 additions & 8 deletions
File tree
- tests/appsec
- contrib_appsec
- iast/fixtures/taint_sinks
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
376 | 376 | | |
377 | 377 | | |
378 | 378 | | |
| 379 | + | |
379 | 380 | | |
380 | 381 | | |
381 | 382 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
3 | 5 | | |
4 | 6 | | |
5 | 7 | | |
| |||
15 | 17 | | |
16 | 18 | | |
17 | 19 | | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
18 | 39 | | |
19 | 40 | | |
20 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
58 | 59 | | |
59 | 60 | | |
60 | 61 | | |
61 | | - | |
62 | | - | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
63 | 65 | | |
64 | 66 | | |
65 | 67 | | |
| |||
90 | 92 | | |
91 | 93 | | |
92 | 94 | | |
93 | | - | |
94 | | - | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
95 | 98 | | |
96 | 99 | | |
97 | 100 | | |
98 | 101 | | |
99 | 102 | | |
100 | 103 | | |
101 | | - | |
102 | | - | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
103 | 107 | | |
104 | 108 | | |
105 | 109 | | |
106 | 110 | | |
107 | 111 | | |
108 | 112 | | |
109 | | - | |
110 | | - | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
111 | 116 | | |
112 | 117 | | |
113 | 118 | | |
| |||
0 commit comments