Skip to content

Commit a7d41a8

Browse files
clean up comments
1 parent 0c62308 commit a7d41a8

2 files changed

Lines changed: 3 additions & 16 deletions

File tree

setup.py

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -128,13 +128,9 @@
128128

129129
BUILD_PROFILING_NATIVE_TESTS = os.getenv("DD_PROFILING_NATIVE_TESTS", "0").lower() in ("1", "yes", "on", "true")
130130

131-
# Opt-in build of the native heap-gotter cdylib (Phase 1: allocation-only native
132-
# heap profiling via GOT rewriting, driven at runtime by the FH eBPF profiler).
133-
# Off by default so normal builds don't pay the extra cargo fetch/compile for the
134-
# `libdd-profiling-heap-gotter` crates.io dependency and mainline wheels don't
135-
# ship the artifact until it graduates. The staging A/B harness sets this to bake
136-
# the artifact into its custom wheels; runtime install is separately gated by
137-
# DD_PROFILING_NATIVE_HEAP_ENABLED.
131+
# Opt-in build of the native heap-gotter cdylib.
132+
# Off by default so normal builds don't pay the extra cargo fetch/compile and
133+
# mainline wheels don't ship the artifact until it GA's.
138134
BUILD_NATIVE_HEAP_GOTTER = os.getenv("DD_PROFILING_NATIVE_HEAP_BUILD", "0").lower() in ("1", "yes", "on", "true")
139135

140136
CURRENT_OS = platform.system()
@@ -857,9 +853,6 @@ def run(self) -> None:
857853
with _time_phase("build_libdd_wrapper"):
858854
self.build_libdd_wrapper()
859855

860-
# Build the native heap-gotter cdylib (opt-in, Linux 64-bit only). It is
861-
# a standalone ctypes-loaded library with no dependency on the other
862-
# extensions, so ordering relative to them does not matter.
863856
if BUILD_NATIVE_HEAP_GOTTER and CURRENT_OS == "Linux" and is_64_bit_python():
864857
with _time_phase("build_heap_gotter"):
865858
self.build_heap_gotter()

src/native_heap_gotter/lib.rs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,6 @@
2525
///
2626
/// Returns the result of `install_heap_overrides`, i.e. whether at least one
2727
/// allocator symbol's GOT entry was resolved and patched (so hooks will run).
28-
/// We deliberately do NOT return `heap_overrides_are_installed()`: that only
29-
/// checks that the upstream global registry was initialized, which is true even
30-
/// for a no-op install that resolved nothing (e.g. a statically linked or
31-
/// custom allocator) or when sampling is disabled. Reporting success there
32-
/// would let the Python activator enable native heap profiling with no live
33-
/// hooks or USDTs.
3428
///
3529
/// Idempotent: safe to call more than once (e.g. after `fork()`). The resolved
3630
/// ORIG slots are process-global and inherited across `fork()`, and upstream

0 commit comments

Comments
 (0)