fix(darwin): close .dylib file before returning from DumpEmbeddedWAF

RomainMuller · RomainMuller · commit 2d6af48239a3 · 2025-08-07T18:42:25.000+02:00
diff --git a/internal/lib/dump_waf_darwin.go b/internal/lib/dump_waf_darwin.go
@@ -51,7 +51,11 @@ func DumpEmbeddedWAF() (path string, closer func() error, err error) {
 		return "", nil, fmt.Errorf("error closing gzip reader: %w", err)
 	}
 
+	if err := file.Close(); err != nil {
+		return "", nil, fmt.Errorf("error closing dylib file: %w", err)
+	}
+
 	return file.Name(), func() error {
-		return errors.Join(file.Close(), os.Remove(file.Name()))
+		return os.Remove(file.Name())
 	}, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,11 @@ func DumpEmbeddedWAF() (path string, closer func() error, err error) {`
`51`	`51`	`return "", nil, fmt.Errorf("error closing gzip reader: %w", err)`
`52`	`52`	`}`
`53`	`53`
	`54`	`+ if err := file.Close(); err != nil {`
	`55`	`+ return "", nil, fmt.Errorf("error closing dylib file: %w", err)`
	`56`	`+ }`
	`57`	`+`
`54`	`58`	`return file.Name(), func() error {`
`55`		`- return errors.Join(file.Close(), os.Remove(file.Name()))`
	`59`	`+ return os.Remove(file.Name())`
`56`	`60`	`}, nil`
`57`	`61`	`}`