Skip to content

Commit 8cab7e7

Browse files
authored
Don't ignore errors during loading libddwaf shared library (#107)
Context: #106 (comment) I am doing this on behave of @eliottness.
1 parent 0ca2830 commit 8cab7e7

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

internal/bindings/waf_dl.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ type wafSymbols struct {
4747
func NewWafDl() (dl *WafDl, err error) {
4848
path, closer, err := lib.DumpEmbeddedWAF()
4949
if err != nil {
50-
return
50+
return nil, fmt.Errorf("dump embedded WAF: %w", err)
5151
}
5252
defer func() {
5353
if rmErr := closer(); rmErr != nil {
@@ -57,7 +57,7 @@ func NewWafDl() (dl *WafDl, err error) {
5757

5858
var handle uintptr
5959
if handle, err = purego.Dlopen(path, purego.RTLD_GLOBAL|purego.RTLD_NOW); err != nil {
60-
return
60+
return nil, fmt.Errorf("load a dynamic library file: %w", err)
6161
}
6262

6363
var symbols wafSymbols
@@ -85,7 +85,7 @@ func NewWafDl() (dl *WafDl, err error) {
8585
if val := os.Getenv(log.EnvVarLogLevel); val != "" {
8686
setLogSym, symErr := purego.Dlsym(handle, "ddwaf_set_log_cb")
8787
if symErr != nil {
88-
return
88+
return nil, fmt.Errorf("get symbol: %w", symErr)
8989
}
9090
logLevel := log.LevelNamed(val)
9191
dl.syscall(setLogSym, log.CallbackFunctionPointer(), uintptr(logLevel))

0 commit comments

Comments
 (0)