velero: extract monkeypatch boilerplate into fixtures in kube_discovery tests

monkeypatch.delenv('DDEV_E2E_ENV_kube_discovery', ...) was repeated as
the first line of 10 test bodies, and monkeypatch.setenv('...PARENT_PYTHON',
...) in 7 more — boilerplate that's easy to get out of sync with a future
test that forgets it. Pull both into an autouse clear_kube_discovery_state
fixture and an opt-in e2e_mode fixture.

Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: vitkyrka

datadog_checks_dev/tests/test_kube_discovery.py

@@ -52,27 +52,32 @@ def write_auto_conf(check_root):
         f.write('ad_identifiers:\n  - test\ndiscovery: {}\ninit_config:\ninstances: []\n')
 
 
-def test_save_and_get_kube_discovery_state(monkeypatch):
+@pytest.fixture(autouse=True)
+def clear_kube_discovery_state(monkeypatch):
     monkeypatch.delenv('DDEV_E2E_ENV_kube_discovery', raising=False)
 
+
+@pytest.fixture
+def e2e_mode(monkeypatch):
+    monkeypatch.setenv('DDEV_E2E_PARENT_PYTHON', '/usr/bin/python3')
+
+
+def test_save_and_get_kube_discovery_state():
     save_kube_discovery_state('/tmp/kubeconfig')
 
     from datadog_checks.dev.kube_discovery import get_kube_discovery_state
 
     assert get_kube_discovery_state() == {'kubeconfig_path': '/tmp/kubeconfig', 'namespace': DISCOVERY_NAMESPACE}
 
 
-def test_get_kube_discovery_state_missing_raises(monkeypatch):
-    monkeypatch.delenv('DDEV_E2E_ENV_kube_discovery', raising=False)
-
+def test_get_kube_discovery_state_missing_raises():
     from datadog_checks.dev.kube_discovery import get_kube_discovery_state
 
     with pytest.raises(AssertionError, match='No kube_discovery state found'):
         get_kube_discovery_state()
 
 
 def test_save_kube_discovery_state_is_noop_when_setup_disabled(monkeypatch):
-    monkeypatch.delenv('DDEV_E2E_ENV_kube_discovery', raising=False)
     monkeypatch.setenv('DDEV_E2E_UP', 'false')
 
     save_kube_discovery_state('/tmp/kubeconfig')
@@ -214,16 +219,11 @@ def test_skips_outside_e2e(self, monkeypatch):
         with pytest.raises(pytest.skip.Exception, match='Not running E2E tests'):
             run_discovery_check_kubernetes(mock.Mock(), mock.Mock())
 
-    def test_missing_state_raises(self, monkeypatch):
-        monkeypatch.delenv('DDEV_E2E_ENV_kube_discovery', raising=False)
-        monkeypatch.setenv('DDEV_E2E_PARENT_PYTHON', '/usr/bin/python3')
-
+    def test_missing_state_raises(self, e2e_mode):
         with pytest.raises(AssertionError, match='No kube_discovery state found'):
             run_discovery_check_kubernetes(mock.Mock(), mock.Mock())
 
-    def test_replays_collector_output(self, monkeypatch):
-        monkeypatch.delenv('DDEV_E2E_ENV_kube_discovery', raising=False)
-        monkeypatch.setenv('DDEV_E2E_PARENT_PYTHON', '/usr/bin/python3')
+    def test_replays_collector_output(self, e2e_mode):
         save_kube_discovery_state('/tmp/kubeconfig', namespace='dd-agent-discovery')
 
         collector = {
@@ -255,9 +255,7 @@ def fake_run_command(command, **kwargs):
             '--json',
         ]
 
-    def test_no_json_output_raises(self, monkeypatch):
-        monkeypatch.delenv('DDEV_E2E_ENV_kube_discovery', raising=False)
-        monkeypatch.setenv('DDEV_E2E_PARENT_PYTHON', '/usr/bin/python3')
+    def test_no_json_output_raises(self, e2e_mode):
         save_kube_discovery_state('/tmp/kubeconfig')
 
         with mock.patch('datadog_checks.dev.kube_discovery.run_command', return_value=result(stdout='no json here')):
@@ -275,16 +273,13 @@ def test_skips_outside_e2e(self, monkeypatch):
                 mock.Mock(), mock.Mock(), mock.Mock(), namespace='keda', pod_name='workload'
             )
 
-    def test_requires_pod_name_or_selector(self, monkeypatch):
-        monkeypatch.delenv('DDEV_E2E_ENV_kube_discovery', raising=False)
+    def test_requires_pod_name_or_selector(self):
         save_kube_discovery_state('/tmp/kubeconfig')
 
         with pytest.raises(TypeError, match='pod_name or pod_selector'):
             assert_all_discovery_candidates_stable_kubernetes(mock.Mock(), mock.Mock(), mock.Mock(), namespace='keda')
 
-    def test_probes_generated_candidates_and_detects_restart(self, monkeypatch):
-        monkeypatch.delenv('DDEV_E2E_ENV_kube_discovery', raising=False)
-        monkeypatch.setenv('DDEV_E2E_PARENT_PYTHON', '/usr/bin/python3')
+    def test_probes_generated_candidates_and_detects_restart(self, e2e_mode):
         save_kube_discovery_state('/tmp/kubeconfig')
 
         class DiscoveryCheck:
@@ -319,9 +314,7 @@ def fake_run_command(command, **kwargs):
         assert DiscoveryCheck.service.host == '10.0.0.5'
         assert [port.number for port in DiscoveryCheck.service.ports] == [8080]
 
-    def test_no_candidates_raises(self, monkeypatch):
-        monkeypatch.delenv('DDEV_E2E_ENV_kube_discovery', raising=False)
-        monkeypatch.setenv('DDEV_E2E_PARENT_PYTHON', '/usr/bin/python3')
+    def test_no_candidates_raises(self, e2e_mode):
         save_kube_discovery_state('/tmp/kubeconfig')
 
         class DiscoveryCheck:
@@ -342,9 +335,7 @@ def fake_run_command(command, **kwargs):
                     DiscoveryCheck, mock.Mock(), mock.Mock(), namespace='keda', pod_name='workload'
                 )
 
-    def test_resolves_pod_via_selector(self, monkeypatch):
-        monkeypatch.delenv('DDEV_E2E_ENV_kube_discovery', raising=False)
-        monkeypatch.setenv('DDEV_E2E_PARENT_PYTHON', '/usr/bin/python3')
+    def test_resolves_pod_via_selector(self, e2e_mode):
         save_kube_discovery_state('/tmp/kubeconfig')
 
         class DiscoveryCheck: