Skip to content

Commit 4315052

Browse files
committed
Keep the pinact check passing on pinact v4
- Add the version comments v4 now requires on every SHA pin in zz-test-worker-poc.yaml. - Correct the slapr comment to 1.0.0, the tag that SHA actually carries. - Exempt dtolnay/rust-toolchain and DataDog/commit-headless, neither of which can carry a comment pinact accepts. - Set fix: false, since as of pinact-action v3 skip_push alone rewrites the files instead of validating them.
1 parent 2a0c67c commit 4315052

4 files changed

Lines changed: 23 additions & 6 deletions

File tree

.github/pinact.yml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,17 @@
22
# GitHub actions are left unpined: .github/workflows/validate-pinned-actions.yml
33
# Used to exclude specific actions from the pin check
44
version: 3
5+
6+
# pinact requires a version comment next to every SHA pin. These two actions
7+
# cannot satisfy that check, so they are exempt from it.
8+
rules:
9+
# Only publishes the `v1` tag; every other ref is a branch, so the pin tracks
10+
# a `master` commit and there is no version to name.
11+
- ignore: true
12+
conditions:
13+
- expr: ActionRepoFullName == "dtolnay/rust-toolchain"
14+
# Tagged as `action/v2.0.3`, and pinact does not recognise prefixed tags as
15+
# version comments.
16+
- ignore: true
17+
conditions:
18+
- expr: ActionRepoFullName == "DataDog/commit-headless"

.github/workflows/slapr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
- SLACK_CHANNEL_ID
1717
- SLACK_CHANNEL_ID_AGENT_INTEGRATIONS_REVIEWS
1818
steps:
19-
- uses: DataDog/slapr@4b5efe2ce585e45898bb88c4fa303e226e8199e4 # Not versioned, latest commit in master as of 2025-05-08
19+
- uses: DataDog/slapr@4b5efe2ce585e45898bb88c4fa303e226e8199e4 # 1.0.0
2020
env:
2121
GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
2222
SLACK_CHANNEL_ID: "${{ secrets[matrix.slack_channel_variable] }}"

.github/workflows/validate-pinned-actions.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@ jobs:
2727
# tibdex/github-app-token@3beb63f4bd073e61482598c45c71c1019b59b73a
2828
uses: suzuki-shunsuke/pinact-action@896d595f299e71d65b9d28349d6956abe144390a # v3.0.0
2929
with:
30+
# As of v3, skip_push alone fixes the files in the workspace instead of
31+
# validating them. fix: false keeps this job a read-only check.
32+
fix: false
3033
skip_push: true
3134

3235
- name: Output pin actions failure message

.github/workflows/zz-test-worker-poc.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
check_run_id: ${{ steps.create_check.outputs.result }}
3030
steps:
3131
- name: Get GitHub token via dd-octo-sts
32-
uses: DataDog/dd-octo-sts-action@acaa02eee7e3bb0839e4272dacb37b8f3b58ba80
32+
uses: DataDog/dd-octo-sts-action@acaa02eee7e3bb0839e4272dacb37b8f3b58ba80 # v1.0.3
3333
id: octo-sts
3434
with:
3535
scope: DataDog/integrations-core
@@ -63,12 +63,12 @@ jobs:
6363

6464
steps:
6565
- name: Check out repository
66-
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
66+
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
6767
with:
6868
ref: ${{ inputs.checkout_ref }}
6969

7070
- name: Set up Python
71-
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405
71+
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
7272
with:
7373
python-version: '3.13'
7474

@@ -97,7 +97,7 @@ jobs:
9797

9898
steps:
9999
- name: Check out repository
100-
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
100+
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
101101
with:
102102
ref: ${{ inputs.checkout_ref }}
103103

@@ -118,7 +118,7 @@ jobs:
118118
contents: read
119119
steps:
120120
- name: Get GitHub token via dd-octo-sts
121-
uses: DataDog/dd-octo-sts-action@acaa02eee7e3bb0839e4272dacb37b8f3b58ba80
121+
uses: DataDog/dd-octo-sts-action@acaa02eee7e3bb0839e4272dacb37b8f3b58ba80 # v1.0.3
122122
id: octo-sts
123123
with:
124124
scope: DataDog/integrations-core

0 commit comments

Comments
 (0)