Skip to content

Commit 583dee6

Browse files
committed
comment
1 parent 9522ac5 commit 583dee6

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

  • datadog_checks_dev/datadog_checks/dev/plugin

datadog_checks_dev/datadog_checks/dev/plugin/pytest.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -288,11 +288,7 @@ def dd_agent_check_discovery(dd_agent_check):
288288
``discovery_timeout`` — all of which can be overridden per call.
289289
290290
Pass ``process=True`` to exercise process-based (rather than container-based)
291-
autodiscovery for a process that is otherwise container-bound: this excludes
292-
the ``docker`` feature for this invocation only (so this run's autodiscovery
293-
never learns about any containers) and, unless overridden, extends the
294-
default timeout to account for the minimum process age that process-based
295-
autodiscovery requires before it recognizes a process as a service.
291+
autodiscovery for a process that is otherwise container-bound.
296292
"""
297293
if not e2e_testing():
298294
pytest.skip('Not running E2E tests')
@@ -307,6 +303,10 @@ def run(*, discovery_min_instances=1, discovery_timeout=None, process=False, **k
307303

308304
if process:
309305
env_vars = kwargs.pop('env_vars', None) or {}
306+
# Exclude the `docker` feature so this run's autodiscovery never
307+
# learns about any containers. This is because process-based
308+
# autodiscovery normally ignores processes if it knows that they are
309+
# inside containers, and we need to override this behavior.
310310
env_vars.setdefault('DD_AUTOCONFIG_EXCLUDE_FEATURES', 'docker')
311311
kwargs['env_vars'] = env_vars
312312

0 commit comments

Comments
 (0)