[DBMON-6789] Implement database_identifier hooks in clickhouse (#24276)

* [DBMON-6789] Implement database_identifier hooks in clickhouse

Co-authored-by: Cursor <cursoragent@cursor.com>

* Add changelog

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: eric-weaver

clickhouse/changelog.d/24276.fixed

@@ -0,0 +1 @@
+Remove duplicated database_identifier logic now provided by the DatabaseCheck base class.

clickhouse/datadog_checks/clickhouse/clickhouse.py

@@ -1,7 +1,6 @@
 # (C) Datadog, Inc. 2019-present
 # All rights reserved
 # Licensed under a 3-clause BSD style license (see LICENSE)
-from string import Template
 from time import time
 
 import clickhouse_connect
@@ -58,7 +57,6 @@ def __init__(self, name, init_config, instances):
         # DBM-related properties (computed lazily)
         self._resolved_hostname = None
         self._database_hostname = None
-        self._database_identifier = None
         self._dbms_version = None
 
         # Track last emission time for database instance metadata (rate limiting)
@@ -353,30 +351,16 @@ def database_hostname(self) -> str:
         return self._database_hostname
 
     @property
-    def database_identifier(self) -> str:
-        """
-        Get a unique identifier for this database instance.
-        Uses the database_identifier template from config, defaulting to "$server:$port:$db".
-        """
-        if self._database_identifier is None:
-            template = Template(self._config.database_identifier.template)
-            tag_dict = {}
-            tags = self.tags.copy()
-            # Sort tags to ensure consistent ordering
-            tags.sort()
-            for t in tags:
-                if ':' in t:
-                    key, value = t.split(':', 1)
-                    if key in tag_dict:
-                        tag_dict[key] += f",{value}"
-                    else:
-                        tag_dict[key] = value
-            # Add connection parameters to the template variables
-            tag_dict['server'] = str(self._config.server)
-            tag_dict['port'] = str(self._config.port)
-            tag_dict['db'] = str(self._config.db)
-            self._database_identifier = template.safe_substitute(**tag_dict)
-        return self._database_identifier
+    def database_identifier_template(self) -> str:
+        return self._config.database_identifier.template
+
+    @property
+    def database_identifier_params(self) -> dict:
+        return {
+            "server": str(self._config.server),
+            "port": str(self._config.port),
+            "db": str(self._config.db),
+        }
 
     @property
     def dbms(self) -> str: