argo_rollouts: add container-based config discovery support

Add a discovery strategy and auto_conf.yaml for the argo-rollouts controller
Deployment so the Agent's Kubernetes Autodiscovery listener can automatically
generate an openmetrics_endpoint configuration for it, and wire the kind-based
E2E test harness up to the new Kubernetes discovery e2e helpers
(setup_discovery_agent/save_kube_discovery_state/run_discovery_check_kubernetes/
assert_all_discovery_candidates_stable_kubernetes).

Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: vitkyrka

argo_rollouts/assets/configuration/spec.yaml

@@ -2,6 +2,12 @@ name: Argo Rollouts
 fleet_configurable: true
 files:
 - name: argo_rollouts.yaml
+  discovery:
+    strategies:
+    - template: discovery/openmetrics_from_ports
+      overrides:
+        port_hints:
+        - 8090
   options:
   - template: init_config
     options:
@@ -13,4 +19,11 @@ files:
         openmetrics_endpoint.value.example: http://localhost:8090/metrics
         openmetrics_endpoint.description: |
           Endpoint exposing the Argo Rollouts Controller's Prometheus metrics. For more information refer to:
-          https://argo-rollouts.readthedocs.io/en/stable/features/controller-metrics/
+          https://argo-rollouts.readthedocs.io/en/stable/features/controller-metrics/
+- name: auto_conf.yaml
+  options:
+  - template: ad_identifiers
+    overrides:
+      value.example:
+      - argo-rollouts
+  - template: auto_conf/discovery

argo_rollouts/changelog.d/24506.added

@@ -0,0 +1 @@
+Add container-based config discovery support.

argo_rollouts/datadog_checks/argo_rollouts/config_models/discovery.py

@@ -0,0 +1,42 @@
+# (C) Datadog, Inc. 2026-present
+# All rights reserved
+# Licensed under a 3-clause BSD style license (see LICENSE)
+
+# This file is autogenerated.
+# To change this file you should edit assets/configuration/spec.yaml and then run the following commands:
+#     ddev -x validate config -s <INTEGRATION_NAME>
+#     ddev -x validate models -s <INTEGRATION_NAME>
+
+from __future__ import annotations
+
+from collections.abc import Iterator
+from typing import Any
+
+from datadog_checks.argo_rollouts.config_models import discovery_overrides
+from datadog_checks.argo_rollouts.config_models.instance import InstanceConfig
+from datadog_checks.argo_rollouts.config_models.shared import SharedConfig
+from datadog_checks.base.utils.discovery import Service, candidate_ports
+
+
+def _generated_candidates(service: Service) -> Iterator[dict[str, Any]]:
+    shared = SharedConfig.model_validate({}, context={'configured_fields': frozenset()}).model_dump(
+        by_alias=True, mode='json', exclude_none=True
+    )
+    # discovery[0]: from_ports
+    for port in candidate_ports(service, [8090]):
+        ctx = {'port': port}
+        instance_data = {
+            'openmetrics_endpoint': 'http://{service.host}:{port.number}/metrics'.format(service=service, **ctx),
+        }
+        instance = InstanceConfig.model_validate(
+            instance_data, context={'configured_fields': frozenset(instance_data)}
+        ).model_dump(by_alias=True, mode='json', exclude_none=True)
+        yield {'init_config': shared, 'instances': [instance]}
+
+
+def candidates(service: Service) -> Iterator[dict[str, Any]]:
+    override = getattr(discovery_overrides, 'candidates', None)
+    if override is None:
+        yield from _generated_candidates(service)
+    else:
+        yield from override(service, default=_generated_candidates)

argo_rollouts/datadog_checks/argo_rollouts/config_models/discovery_overrides.py

@@ -0,0 +1,12 @@
+# (C) Datadog, Inc. 2026-present
+# All rights reserved
+# Licensed under a 3-clause BSD style license (see LICENSE)
+
+# Override the generated discovery candidates() for this integration.
+#
+# Define a candidates(service, default) function to wrap or replace the generated
+# candidate generation. `default` is the generated generator; call it to reuse
+# the spec-driven candidates, or ignore it to replace them entirely.
+#
+# def candidates(service, default):
+#     yield from default(service)

argo_rollouts/datadog_checks/argo_rollouts/config_models/discovery_strategies.py

@@ -0,0 +1,18 @@
+# (C) Datadog, Inc. 2026-present
+# All rights reserved
+# Licensed under a 3-clause BSD style license (see LICENSE)
+
+# Here you can define custom (local:) discovery strategies for this integration.
+#
+# Decorate a generator with @discovery_strategy (imported from
+# datadog_checks.base.utils.discovery) and reference it from the spec discovery
+# stanza as `strategy: local:<function_name>`. The function receives the
+# discovered Service plus the inputs declared in the spec and yields one context
+# (ctx) mapping per candidate, exposing the keys listed in `provides`.
+#
+# from datadog_checks.base.utils.discovery import discovery_strategy
+#
+# @discovery_strategy(provides=('svc',))
+# def from_some_config(service, config_path):
+#     ...
+#     yield {'svc': ...}

argo_rollouts/datadog_checks/argo_rollouts/data/auto_conf.yaml

@@ -0,0 +1,19 @@
+## @param ad_identifiers - list of strings - required
+## A list of container identifiers that are used by Autodiscovery to identify
+## which container the check should be run against. For more information, see:
+## https://docs.datadoghq.com/agent/guide/ad_identifiers/
+#
+ad_identifiers:
+  - argo-rollouts
+
+## Enables configuration discovery
+#
+discovery: {}
+
+## Unused init configuration
+#
+init_config:
+
+## Unused instance configuration
+#
+instances: []

argo_rollouts/pyproject.toml

@@ -29,7 +29,7 @@ classifiers = [
     "Topic :: System :: Monitoring",
 ]
 dependencies = [
-    "datadog-checks-base>=37.33.0",
+    "datadog-checks-base>=37.41.0",
 ]
 dynamic = [
     "version",

argo_rollouts/tests/conftest.py

@@ -8,6 +8,7 @@
 
 from datadog_checks.dev import get_here
 from datadog_checks.dev.kind import kind_run
+from datadog_checks.dev.kube_discovery import save_kube_discovery_state, setup_discovery_agent
 from datadog_checks.dev.kube_port_forward import port_forward
 from datadog_checks.dev.subprocess import run_command
 
@@ -28,6 +29,8 @@ def setup_argo_rollouts():
 @pytest.fixture(scope='session')
 def dd_environment():
     with kind_run(conditions=[setup_argo_rollouts], sleep=30) as kubeconfig, ExitStack() as stack:
+        setup_discovery_agent(kubeconfig)
+        save_kube_discovery_state(kubeconfig)
         argo_rollouts_host, argo_rollouts_port = stack.enter_context(
             port_forward(kubeconfig, 'argo-rollouts', 8090, 'deployment', 'argo-rollouts')
         )

argo_rollouts/tests/test_e2e.py

@@ -1,7 +1,14 @@
 # (C) Datadog, Inc. 2024-present
 # All rights reserved
 # Licensed under a 3-clause BSD style license (see LICENSE)
+import pytest
+
+from datadog_checks.argo_rollouts import ArgoRolloutsCheck
 from datadog_checks.base.constants import ServiceCheck
+from datadog_checks.dev.kube_discovery import (
+    assert_all_discovery_candidates_stable_kubernetes,
+    run_discovery_check_kubernetes,
+)
 from datadog_checks.dev.utils import assert_service_checks
 
 
@@ -10,3 +17,22 @@ def test_e2e_openmetrics_v2(dd_agent_check):
 
     aggregator.assert_service_check('argo_rollouts.openmetrics.health', ServiceCheck.OK, count=1)
     assert_service_checks(aggregator)
+
+
+@pytest.mark.e2e
+def test_e2e_discovery(aggregator, datadog_agent):
+    run_discovery_check_kubernetes(aggregator, datadog_agent)
+
+    aggregator.assert_service_check('argo_rollouts.openmetrics.health', ServiceCheck.OK, count=1)
+    assert_service_checks(aggregator)
+
+
+@pytest.mark.e2e
+def test_e2e_discovery_all_candidates(aggregator, datadog_agent):
+    assert_all_discovery_candidates_stable_kubernetes(
+        ArgoRolloutsCheck,
+        aggregator,
+        datadog_agent,
+        namespace='argo-rollouts',
+        pod_selector='app.kubernetes.io/name=argo-rollouts',
+    )