Skip to content

Commit c7574be

Browse files
committed
tekton: use named metrics port for discovery
1 parent e380c82 commit c7574be

2 files changed

Lines changed: 9 additions & 8 deletions

File tree

tekton/assets/configuration/spec.yaml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,12 @@ files:
44
- name: tekton.yaml
55
discovery:
66
strategies:
7-
- strategy: from_ports
8-
port_hints:
9-
- 9090
10-
candidates:
11-
- pipelines_controller_endpoint: "http://{service.host}:{port.number}/metrics"
7+
- template: discovery/openmetrics_from_named_ports
8+
overrides:
9+
port_names:
10+
- metrics
11+
candidates:
12+
- pipelines_controller_endpoint: "http://{service.host}:{port.number}/metrics"
1213
options:
1314
- template: init_config
1415
options:

tekton/datadog_checks/tekton/config_models/discovery.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
from collections.abc import Iterator
1313
from typing import Any
1414

15-
from datadog_checks.base.utils.discovery import Service, candidate_ports
15+
from datadog_checks.base.utils.discovery import Service, candidate_ports_by_name
1616
from datadog_checks.tekton.config_models import discovery_overrides
1717
from datadog_checks.tekton.config_models.instance import InstanceConfig
1818
from datadog_checks.tekton.config_models.shared import SharedConfig
@@ -22,8 +22,8 @@ def _generated_candidates(service: Service) -> Iterator[dict[str, Any]]:
2222
shared = SharedConfig.model_validate({}, context={'configured_fields': frozenset()}).model_dump(
2323
by_alias=True, mode='json', exclude_none=True
2424
)
25-
# discovery[0]: from_ports
26-
for port in candidate_ports(service, [9090]):
25+
# discovery[0]: from_named_ports
26+
for port in candidate_ports_by_name(service, ['metrics']):
2727
ctx = {'port': port}
2828
instance_data = {
2929
'pipelines_controller_endpoint': 'http://{service.host}:{port.number}/metrics'.format(

0 commit comments

Comments
 (0)