velero: add container-based config discovery support

Adds a discovery: strategy to spec.yaml (from_ports on port 8085, the
metrics port shared by the velero server and node-agent components), the
generated auto_conf.yaml/discovery config models, and Kubernetes-native
discovery E2E tests using the new kube_discovery helpers.

Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: vitkyrka

datadog_checks_dev/changelog.d/24507.added

@@ -0,0 +1 @@
+Add ``kube_discovery`` e2e test helpers for exercising Kubernetes/Kubelet Autodiscovery.

datadog_checks_dev/datadog_checks/dev/kube_discovery.py

@@ -2,6 +2,12 @@ name: Velero
 fleet_configurable: true
 files:
 - name: velero.yaml
+  discovery:
+    strategies:
+    - template: discovery/openmetrics_from_ports
+      overrides:
+        port_hints:
+        - 8085
   options:
   - template: init_config
     options:
@@ -14,3 +20,10 @@ files:
     - type: docker
       source: velero
       service: <SERVICE>
+- name: auto_conf.yaml
+  options:
+  - template: ad_identifiers
+    overrides:
+      value.example:
+      - velero
+  - template: auto_conf/discovery

datadog_checks_dev/tests/test_kube_discovery.py

@@ -0,0 +1 @@
+Add container-based config discovery support.

velero/assets/configuration/spec.yaml

@@ -0,0 +1,42 @@
+# (C) Datadog, Inc. 2026-present
+# All rights reserved
+# Licensed under a 3-clause BSD style license (see LICENSE)
+
+# This file is autogenerated.
+# To change this file you should edit assets/configuration/spec.yaml and then run the following commands:
+#     ddev -x validate config -s <INTEGRATION_NAME>
+#     ddev -x validate models -s <INTEGRATION_NAME>
+
+from __future__ import annotations
+
+from collections.abc import Iterator
+from typing import Any
+
+from datadog_checks.base.utils.discovery import Service, candidate_ports
+from datadog_checks.velero.config_models import discovery_overrides
+from datadog_checks.velero.config_models.instance import InstanceConfig
+from datadog_checks.velero.config_models.shared import SharedConfig
+
+
+def _generated_candidates(service: Service) -> Iterator[dict[str, Any]]:
+    shared = SharedConfig.model_validate({}, context={'configured_fields': frozenset()}).model_dump(
+        by_alias=True, mode='json', exclude_none=True
+    )
+    # discovery[0]: from_ports
+    for port in candidate_ports(service, [8085]):
+        ctx = {'port': port}
+        instance_data = {
+            'openmetrics_endpoint': 'http://{service.host}:{port.number}/metrics'.format(service=service, **ctx),
+        }
+        instance = InstanceConfig.model_validate(
+            instance_data, context={'configured_fields': frozenset(instance_data)}
+        ).model_dump(by_alias=True, mode='json', exclude_none=True)
+        yield {'init_config': shared, 'instances': [instance]}
+
+
+def candidates(service: Service) -> Iterator[dict[str, Any]]:
+    override = getattr(discovery_overrides, 'candidates', None)
+    if override is None:
+        yield from _generated_candidates(service)
+    else:
+        yield from override(service, default=_generated_candidates)

velero/changelog.d/24507.added

@@ -0,0 +1,12 @@
+# (C) Datadog, Inc. 2026-present
+# All rights reserved
+# Licensed under a 3-clause BSD style license (see LICENSE)
+
+# Override the generated discovery candidates() for this integration.
+#
+# Define a candidates(service, default) function to wrap or replace the generated
+# candidate generation. `default` is the generated generator; call it to reuse
+# the spec-driven candidates, or ignore it to replace them entirely.
+#
+# def candidates(service, default):
+#     yield from default(service)

velero/datadog_checks/velero/config_models/discovery.py

@@ -0,0 +1,18 @@
+# (C) Datadog, Inc. 2026-present
+# All rights reserved
+# Licensed under a 3-clause BSD style license (see LICENSE)
+
+# Here you can define custom (local:) discovery strategies for this integration.
+#
+# Decorate a generator with @discovery_strategy (imported from
+# datadog_checks.base.utils.discovery) and reference it from the spec discovery
+# stanza as `strategy: local:<function_name>`. The function receives the
+# discovered Service plus the inputs declared in the spec and yields one context
+# (ctx) mapping per candidate, exposing the keys listed in `provides`.
+#
+# from datadog_checks.base.utils.discovery import discovery_strategy
+#
+# @discovery_strategy(provides=('svc',))
+# def from_some_config(service, config_path):
+#     ...
+#     yield {'svc': ...}

velero/datadog_checks/velero/config_models/discovery_overrides.py

@@ -0,0 +1,19 @@
+## @param ad_identifiers - list of strings - required
+## A list of container identifiers that are used by Autodiscovery to identify
+## which container the check should be run against. For more information, see:
+## https://docs.datadoghq.com/agent/guide/ad_identifiers/
+#
+ad_identifiers:
+  - velero
+
+## Enables configuration discovery
+#
+discovery: {}
+
+## Unused init configuration
+#
+init_config:
+
+## Unused instance configuration
+#
+instances: []

velero/datadog_checks/velero/config_models/discovery_strategies.py

@@ -9,6 +9,7 @@
 from datadog_checks.dev import TempDir, run_command
 from datadog_checks.dev.fs import path_join
 from datadog_checks.dev.kind import KindLoad, kind_run
+from datadog_checks.dev.kube_discovery import save_kube_discovery_state, setup_discovery_agent
 from datadog_checks.dev.kube_port_forward import port_forward
 
 from .common import MOCKED_INSTANCE, PORT
@@ -88,6 +89,9 @@ def dd_environment():
                 "HELM_CONFIG_HOME": path_join(helm_dir, 'Preferences'),
             },
         ) as kubeconfig:
+            setup_discovery_agent(kubeconfig)
+            save_kube_discovery_state(kubeconfig)
+
             with ExitStack() as stack:
                 ip_ports = [
                     stack.enter_context(port_forward(kubeconfig, 'velero', PORT, ressource, name))