Skip to content

Commit 4287eda

Browse files
committed
issue filled out with TODOs
1 parent b1baed0 commit 4287eda

1 file changed

Lines changed: 34 additions & 1 deletion

File tree

issues/disruption-probe.md

Lines changed: 34 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,34 @@
1-
# Use case
1+
# Feature request / problem statement
2+
3+
Our users rely heavily on eviction and pod disruption budgets for stability and for fleet management, see TODO link talks for more context.
4+
5+
An issue our users often run into is that the do not want their pod to be evicted temporarily. The readiness probe is not an option because the pods critically do still need to serve traffic. TODO small justification / real example.
6+
7+
The request is to have a mechanism provided by Kubernetes that can distinguish between whether a pod should be routable (readiness) and whether a pod should be disruptable. The solution outlined here is to have a disruption probe and pod status, similar to readiness.
8+
9+
# Proposal
10+
11+
The proposal is to add an additional probe the kubelet would perform, similar to [liveness and readiness](https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readine), for example:
12+
13+
```
14+
TODO example, it's very simple
15+
```
16+
17+
Similarly there will be a corresponding status on the pod.
18+
19+
```
20+
TODO example, it's very simple
21+
```
22+
23+
## Behavior, Implementation, and Details
24+
25+
Only pods with a healthy disruption status (see above status) will be eiligble for disruption. This means the disruption controller will need to take this into account *instead* of the readiness of pods it looks at today.
26+
27+
There is a concern around starvation, meaning that pods could in theory (and likely in practice) never allow themselves to be disrupted. This concern exists for readiness too, but there is a natural pushback on the user as during this time the won't be routed to so it cannot continue business as usual. It may be worth considering limitations on how long a pod can be considered "not disruptable".
28+
29+
TODO more info on how it works with readiness and how importance of failing closed
30+
31+
## Next steps
32+
33+
We are hoping to gauge interest with a lighter weight issue, if there is interest we will convert to a KEP.
34+

0 commit comments

Comments
 (0)