Fix dogstatsd property test (#1413)

* Fix dogstatsd property test

This commit fixes our prefix length calculation, triggered only when max_bytes
is low. We were removing the size of a `usize` when `u32` was appropriate, as
that is the proper length of the payload prefix.

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>

* clippy

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>

* lifetime ding

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>

---------

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>

Author: blt

lading_payload/src/dogstatsd.rs

@@ -29,6 +29,7 @@ pub mod service_check;
 
 const MAX_CONTEXTS: u32 = 1_000_000;
 const MAX_NAME_LENGTH: u16 = 4_096;
+const LENGTH_PREFIX_SIZE: usize = std::mem::size_of::<u32>();
 
 /// Weights for `DogStatsD` kinds: metrics, events, service checks
 ///
@@ -490,7 +491,7 @@ impl DogStatsD {
     /// # Errors
     ///
     /// Function will error if a member could not be generated
-    pub fn generate<R>(&self, rng: &mut R) -> Result<Member, crate::Error>
+    pub fn generate<R>(&self, rng: &mut R) -> Result<Member<'_>, crate::Error>
     where
         R: rand::Rng + ?Sized,
     {
@@ -566,9 +567,15 @@ impl DogStatsD {
         R: Rng + Sized,
         W: Write,
     {
-        let mut bytes_remaining = max_bytes.saturating_sub(std::mem::size_of::<usize>());
+        // If max_bytes is less than the length prefix size, we can't write anything
+        if max_bytes < LENGTH_PREFIX_SIZE {
+            return Ok(());
+        }
+
+        let mut bytes_remaining = max_bytes.saturating_sub(LENGTH_PREFIX_SIZE);
         let mut members = Vec::new();
-        // generate as many messages as we can fit
+        // Generate as many messages as we can fit, If we couldn't fit any
+        // members, don't write anything.
         loop {
             let member: Member = self.member_generator.generate(&mut rng)?;
             let encoding = format!("{member}");
@@ -581,7 +588,7 @@ impl DogStatsD {
                 None => break,
             }
         }
-        if bytes_remaining == max_bytes {
+        if members.is_empty() {
             return Ok(());
         }