Merge branch 'main' into paullgdc/remote_config/agentless_fetcher

Author: paullegranddc

.github/CODEOWNERS

@@ -29,9 +29,9 @@ clippy.toml                          @DataDog/libdatadog
 cmake/                               @DataDog/apm-common-components-core
 CONTRIBUTING.md                      @DataDog/libdatadog-core
 Cross.toml                           @DataDog/apm-common-components-core
-datadog-ffe                          @DataDog/feature-flagging-and-experimentation-sdk
-datadog-ffe-test-suite               @DataDog/feature-flagging-and-experimentation-sdk
-datadog-ffe-ffi                      @DataDog/feature-flagging-and-experimentation-sdk
+libdd-ffe                            @DataDog/feature-flagging-and-experimentation-sdk
+libdd-ffe-test-suite                 @DataDog/feature-flagging-and-experimentation-sdk
+libdd-ffe-ffi                        @DataDog/feature-flagging-and-experimentation-sdk
 datadog-ipc*/                        @DataDog/libdatadog-php
 datadog-live-debugger*/              @DataDog/libdatadog-php @DataDog/libdatadog-apm
 datadog-profiling-replayer           @DataDog/libdatadog-profiling
@@ -43,21 +43,22 @@ deny.toml                            @DataDog/libdatadog
 docker-bake.hcl                      @DataDog/apm-common-components-core
 docs                                 @DataDog/libdatadog
 examples                             @DataDog/libdatadog
+libdd-agent-client                   @DataDog/apm-common-components-core
 libdd-alloc/                         @DataDog/libdatadog-profiling
 libdd-capabilities*/                 @DataDog/apm-common-components-core
 libdd-common*/                       @DataDog/libdatadog
 libdd-crashtracker*/                 @DataDog/libdatadog-profiling
 libdd-data-pipeline*/                @DataDog/libdatadog-apm
 libdd-ddsketch*/                     @DataDog/libdatadog-apm @DataDog/apm-common-components-core
 libdd-dogstatsd-client               @DataDog/apm-common-components-core
-libdd-profiling-heap-*/                        @DataDog/libdatadog-profiling
+libdd-gotter/                      @DataDog/libdatadog @DataDog/libdatadog-profiling
 libdd-http-client                    @DataDog/apm-common-components-core
-libdd-agent-client                   @DataDog/apm-common-components-core
 libdd-library-config*/               @DataDog/apm-sdk-capabilities-rust
 libdd-log*/                          @DataDog/apm-common-components-core
 libdd-otel-thread-ctx/               @DataDog/apm-common-components-core
 libdd-otel-thread-ctx-ffi/           @DataDog/apm-common-components-core
 libdd-profiling*/                    @DataDog/libdatadog-profiling
+libdd-profiling-heap-*/              @DataDog/libdatadog-profiling
 libdd-sampling/                      @DataDog/apm-common-components-core
 libdd-shared-runtime*/               @DataDog/apm-common-components-core
 libdd-telemetry*/                    @DataDog/apm-common-components-core

.gitmodules

@@ -1,3 +1,3 @@
 [submodule "datadog-ffe-test-suite/ffe-system-test-data"]
-	path = datadog-ffe-test-suite/ffe-system-test-data
+	path = libdd-ffe-test-suite/ffe-system-test-data
 	url = https://github.com/DataDog/ffe-system-test-data.git

AGENTS.md

@@ -73,7 +73,7 @@ libdatadog is integrated into many runtimes and languages via FFI, and runs in D
 - Bubble errors up to the library caller with detail — prefer structured error enums (e.g. `thiserror`) over opaque strings.
 - Stay free of global effects unless a feature requires them: no spawning threads, no globals, no reading environment variables behind the caller's back.
 - Care about performance, especially memory allocations on hot paths.
-- Panics across FFI boundaries are undefined behavior. FFI entry points must catch unwinds (e.g. `std::panic::catch_unwind`) and convert them into error returns rather than letting them propagate into the caller's runtime.
+- A panic that reaches an `extern "C"` boundary aborts the host process. FFI entry points must catch unwinds (e.g. `std::panic::catch_unwind`) and convert them into error returns rather than letting them propagate into the caller's runtime. Whether a release artifact gets panic containment is decided by `builder` alone, through its `catch_panic` feature (a default), which propagates to the `catch_panic` feature in `libdd-profiling-ffi/Cargo.toml`. Projects building their own flavor with `builder`'s default features off ask for `catch_panic` explicitly; leaving it out yields abort-on-panic semantics. The FFI examples are what verify containment is on for our own release process.
 - The C FFI does **not** offer C ABI backward-compatibility guarantees: callers (Datadog SDKs) pin to specific libdatadog versions, so `#[repr(C)]` layouts, function signatures, and enum variants may change between releases.
 
 ### Cryptography

Cargo.lock

@@ -7,13 +7,14 @@ members = [
   "libdd-alloc",
   "libdd-profiling-heap-sampler",
   "libdd-profiling-heap-allocator",
+  "libdd-gotter",
   "libdd-profiling-heap-gotter",
   "libdd-profiling-heap-gotter-ffi",
   "libdd-crashtracker",
   "libdd-crashtracker-ffi",
-  "datadog-ffe",
-  "datadog-ffe-test-suite",
-  "datadog-ffe-ffi",
+  "libdd-ffe",
+  "libdd-ffe-test-suite",
+  "libdd-ffe-ffi",
   "datadog-ipc",
   "datadog-ipc-macros",
   "libdd-library-config",

Cargo.toml

@@ -221,7 +221,7 @@ js-sys,https://github.com/rustwasm/wasm-bindgen/tree/master/crates/js-sys,MIT OR
 kernel32-sys,https://github.com/retep998/winapi-rs,MIT,Peter Atashian <retep998@gmail.com>
 kv-log-macro,https://github.com/yoshuawuyts/kv-log-macro,MIT OR Apache-2.0,Yoshua Wuyts <yoshuawuyts@gmail.com>
 lazy_static,https://github.com/rust-lang-nursery/lazy-static.rs,MIT OR Apache-2.0,Marvin Löbel <loebel.marvin@gmail.com>
-libc,https://github.com/rust-lang/libc,MIT OR Apache-2.0,The Rust Project Developers
+libc,https://github.com/rust-lang/libc,MIT OR Apache-2.0,The libc Authors
 libdd-libunwind-sys,https://github.com/DataDog/libdatadog/tree/main/libdd-libunwind-sys,Apache-2.0,The libdd-libunwind-sys Authors
 libloading,https://github.com/nagisa/rust_libloading,ISC,Simonas Kazlauskas <libloading@kazlauskas.me>
 libredox,https://gitlab.redox-os.org/redox-os/libredox,MIT,4lDO2 <4lDO2@protonmail.com>

LICENSE-3rdparty.csv

@@ -20,6 +20,7 @@ default = [
   "ddsketch",
   "ffe",
   "shared-runtime",
+  "catch_panic",
 ]
 crashtracker = []
 profiling = []
@@ -35,11 +36,11 @@ ddsketch = []
 ffe = []
 shared-runtime = []
 otel-thread-ctx = []
+catch_panic = []
 regex-lite = ["libdd-common/regex-lite"]
 
 [lib]
 bench = false
-test = false
 doctest = false
 
 [dependencies]

builder/Cargo.toml

@@ -9,6 +9,7 @@ use builder::builder::Builder;
 use builder::common::Common;
 #[cfg(feature = "crashtracker")]
 use builder::crashtracker::CrashTracker;
+use builder::features::{profiling_features, Selection};
 #[cfg(feature = "profiling")]
 use builder::profiling::Profiling;
 use builder::utils::project_root;
@@ -54,34 +55,7 @@ pub fn main() {
         host.clone()
     };
 
-    #[allow(clippy::vec_init_then_push)]
-    let features = {
-        #[allow(unused_mut)]
-        let mut f: Vec<String> = vec![];
-        #[cfg(feature = "telemetry")]
-        f.push("ddtelemetry-ffi".to_string());
-        #[cfg(feature = "data-pipeline")]
-        f.push("data-pipeline-ffi".to_string());
-        #[cfg(feature = "data-pipeline-compression")]
-        f.push("data-pipeline-compression".to_string());
-        #[cfg(feature = "crashtracker")]
-        f.push("crashtracker-ffi".to_string());
-        #[cfg(feature = "symbolizer")]
-        f.push("symbolizer".to_string());
-        #[cfg(feature = "library-config")]
-        f.push("datadog-library-config-ffi".to_string());
-        #[cfg(feature = "log")]
-        f.push("datadog-log-ffi".to_string());
-        #[cfg(feature = "ddsketch")]
-        f.push("ddsketch-ffi".to_string());
-        #[cfg(feature = "ffe")]
-        f.push("datadog-ffe-ffi".to_string());
-        #[cfg(feature = "shared-runtime")]
-        f.push("shared-runtime".to_string());
-        #[cfg(feature = "otel-thread-ctx")]
-        f.push("otel-thread-ctx-ffi".to_string());
-        f
-    };
+    let features = profiling_features(&Selection::from_cargo_features());
 
     let mut builder = Builder::new(
         source_path.to_str().unwrap(),

builder/src/bin/release.rs

@@ -40,7 +40,7 @@ use crate::utils::{file_replace, project_root};
 ///         Ok(())
 ///     }
 /// }
-/// let mut builder = Builder::new("source", "target", "arch", "features", "profile", "version");
+/// let mut builder = Builder::new("source", "target", "arch", "profile", "features", "version");
 /// let core = Box::new(Core {
 ///     version: builder.version.clone(),
 /// });