Skip to content

Commit 2f7c78e

Browse files
authored
fix npe on some metrics for vcenter vms (open-telemetry#41701)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description I believe that this should be the only nullable field improperly accessed within this file. ```go // The ConfigInfo data object type encapsulates the configuration settings and // virtual hardware for a virtual machine. // // This type holds all the information // that is present in the .vmx configuration file for the virtual machine. type VirtualMachineConfigInfo struct { ``` I'm thinking users may have created a machine and attached the vmdk to it and thats may be the potential cause? Either way this should resolve the NPE and shouldn't crash the collector when we encounter these. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#41018 <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation Changelog
1 parent 7589c18 commit 2f7c78e

File tree

2 files changed

+28
-1
lines changed

2 files changed

+28
-1
lines changed

.chloggen/main.yaml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: bug_fix
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: vcenterreceiver
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Fixes a potential NPE during VM collection
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [41018]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# If your change doesn't affect end users or the exported elements of any package,
21+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
22+
# Optional: The change log or logs in which this entry should be included.
23+
# e.g. '[user]' or '[user, api]'
24+
# Include 'user' if the change is relevant to end users.
25+
# Include 'api' if there is a change to a library API.
26+
# Default: '[user]'
27+
change_logs: []

receiver/vcenterreceiver/processors.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ func (v *vcenterMetricScraper) buildVMMetrics(
307307
}
308308

309309
groupInfo = &vmGroupInfo{poweredOff: 0, poweredOn: 0, suspended: 0, templates: 0}
310-
if vm.Config.Template {
310+
if vm.Config != nil && vm.Config.Template {
311311
groupInfo.templates++
312312
} else {
313313
switch vm.Runtime.PowerState {

0 commit comments

Comments
 (0)