Skip to content

Commit ae957a6

Browse files
committed
[chore] update configgrpc.ServerConfig and configgrpc.ClientConfig to use configoptional for Keepalive, Auth, and ServerConfig.TLS
1 parent 7ab9c12 commit ae957a6

File tree

24 files changed

+73
-59
lines changed

24 files changed

+73
-59
lines changed

exporter/coralogixexporter/factory_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import (
1414
"go.opentelemetry.io/collector/config/configcompression"
1515
"go.opentelemetry.io/collector/config/configgrpc"
1616
"go.opentelemetry.io/collector/config/configopaque"
17+
"go.opentelemetry.io/collector/config/configoptional"
1718
"go.opentelemetry.io/collector/config/configretry"
1819
"go.opentelemetry.io/collector/config/configtls"
1920
"go.opentelemetry.io/collector/exporter/exporterhelper"
@@ -104,11 +105,11 @@ func TestCreateTraces(t *testing.T) {
104105
config: &Config{
105106
Traces: configgrpc.ClientConfig{
106107
Endpoint: endpoint,
107-
Keepalive: &configgrpc.KeepaliveClientConfig{
108+
Keepalive: configoptional.Some(configgrpc.KeepaliveClientConfig{
108109
Time: 30 * time.Second,
109110
Timeout: 25 * time.Second,
110111
PermitWithoutStream: true,
111-
},
112+
}),
112113
},
113114
},
114115
},

exporter/coralogixexporter/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ require (
1010
go.opentelemetry.io/collector/config/configcompression v1.35.1-0.20250708151327-74cb2f311035
1111
go.opentelemetry.io/collector/config/configgrpc v0.129.1-0.20250708151327-74cb2f311035
1212
go.opentelemetry.io/collector/config/configopaque v1.35.1-0.20250708151327-74cb2f311035
13+
go.opentelemetry.io/collector/config/configoptional v0.129.0
1314
go.opentelemetry.io/collector/config/configretry v1.35.1-0.20250708151327-74cb2f311035
1415
go.opentelemetry.io/collector/config/configtls v1.35.1-0.20250708151327-74cb2f311035
1516
go.opentelemetry.io/collector/confmap v1.35.1-0.20250708151327-74cb2f311035
@@ -59,7 +60,6 @@ require (
5960
go.opentelemetry.io/collector/config/configauth v0.129.1-0.20250708151327-74cb2f311035 // indirect
6061
go.opentelemetry.io/collector/config/configmiddleware v0.129.1-0.20250708151327-74cb2f311035 // indirect
6162
go.opentelemetry.io/collector/config/confignet v1.35.1-0.20250708151327-74cb2f311035 // indirect
62-
go.opentelemetry.io/collector/config/configoptional v0.129.0 // indirect
6363
go.opentelemetry.io/collector/consumer/consumererror/xconsumererror v0.129.1-0.20250708151327-74cb2f311035 // indirect
6464
go.opentelemetry.io/collector/consumer/consumertest v0.129.1-0.20250708151327-74cb2f311035 // indirect
6565
go.opentelemetry.io/collector/consumer/xconsumer v0.129.1-0.20250708151327-74cb2f311035 // indirect

exporter/opencensusexporter/config_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import (
1313
"go.opentelemetry.io/collector/component"
1414
"go.opentelemetry.io/collector/config/configgrpc"
1515
"go.opentelemetry.io/collector/config/configopaque"
16+
"go.opentelemetry.io/collector/config/configoptional"
1617
"go.opentelemetry.io/collector/config/configretry"
1718
"go.opentelemetry.io/collector/config/configtls"
1819
"go.opentelemetry.io/collector/confmap/confmaptest"
@@ -64,11 +65,11 @@ func TestLoadConfig(t *testing.T) {
6465
},
6566
Insecure: false,
6667
},
67-
Keepalive: &configgrpc.KeepaliveClientConfig{
68+
Keepalive: configoptional.Some(configgrpc.KeepaliveClientConfig{
6869
Time: 20,
6970
PermitWithoutStream: true,
7071
Timeout: 30,
71-
},
72+
}),
7273
WriteBufferSize: 512 * 1024,
7374
BalancerName: "round_robin",
7475
},

exporter/opencensusexporter/factory_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import (
1414
"go.opentelemetry.io/collector/component/componenttest"
1515
"go.opentelemetry.io/collector/config/configgrpc"
1616
"go.opentelemetry.io/collector/config/configopaque"
17+
"go.opentelemetry.io/collector/config/configoptional"
1718
"go.opentelemetry.io/collector/config/configtls"
1819
"go.opentelemetry.io/collector/exporter/exportertest"
1920

@@ -75,11 +76,11 @@ func TestCreateTraces(t *testing.T) {
7576
config: &Config{
7677
ClientConfig: configgrpc.ClientConfig{
7778
Endpoint: endpoint,
78-
Keepalive: &configgrpc.KeepaliveClientConfig{
79+
Keepalive: configoptional.Some(configgrpc.KeepaliveClientConfig{
7980
Time: 30 * time.Second,
8081
Timeout: 25 * time.Second,
8182
PermitWithoutStream: true,
82-
},
83+
}),
8384
},
8485
NumWorkers: 3,
8586
},

exporter/opencensusexporter/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ require (
1212
go.opentelemetry.io/collector/component/componenttest v0.129.1-0.20250708151327-74cb2f311035
1313
go.opentelemetry.io/collector/config/configgrpc v0.129.1-0.20250708151327-74cb2f311035
1414
go.opentelemetry.io/collector/config/configopaque v1.35.1-0.20250708151327-74cb2f311035
15+
go.opentelemetry.io/collector/config/configoptional v0.129.0
1516
go.opentelemetry.io/collector/config/configretry v1.35.1-0.20250708151327-74cb2f311035
1617
go.opentelemetry.io/collector/config/configtls v1.35.1-0.20250708151327-74cb2f311035
1718
go.opentelemetry.io/collector/confmap v1.35.1-0.20250708151327-74cb2f311035
@@ -67,7 +68,6 @@ require (
6768
go.opentelemetry.io/collector/config/configcompression v1.35.1-0.20250708151327-74cb2f311035 // indirect
6869
go.opentelemetry.io/collector/config/configmiddleware v0.129.1-0.20250708151327-74cb2f311035 // indirect
6970
go.opentelemetry.io/collector/config/confignet v1.35.1-0.20250708151327-74cb2f311035 // indirect
70-
go.opentelemetry.io/collector/config/configoptional v0.129.0 // indirect
7171
go.opentelemetry.io/collector/consumer/consumererror v0.129.1-0.20250708151327-74cb2f311035 // indirect
7272
go.opentelemetry.io/collector/consumer/xconsumer v0.129.1-0.20250708151327-74cb2f311035 // indirect
7373
go.opentelemetry.io/collector/exporter/xexporter v0.129.1-0.20250708151327-74cb2f311035 // indirect

exporter/otelarrowexporter/config_test.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import (
1717
"go.opentelemetry.io/collector/config/configcompression"
1818
"go.opentelemetry.io/collector/config/configgrpc"
1919
"go.opentelemetry.io/collector/config/configopaque"
20+
"go.opentelemetry.io/collector/config/configoptional"
2021
"go.opentelemetry.io/collector/config/configretry"
2122
"go.opentelemetry.io/collector/config/configtls"
2223
"go.opentelemetry.io/collector/confmap/confmaptest"
@@ -83,14 +84,14 @@ func TestUnmarshalConfig(t *testing.T) {
8384
},
8485
Insecure: false,
8586
},
86-
Keepalive: &configgrpc.KeepaliveClientConfig{
87+
Keepalive: configoptional.Some(configgrpc.KeepaliveClientConfig{
8788
Time: 20 * time.Second,
8889
PermitWithoutStream: true,
8990
Timeout: 30 * time.Second,
90-
},
91+
}),
9192
WriteBufferSize: 512 * 1024,
9293
BalancerName: "experimental",
93-
Auth: &configauth.Config{AuthenticatorID: component.NewID(component.MustNewType("nop"))},
94+
Auth: configoptional.Some(configauth.Config{AuthenticatorID: component.NewID(component.MustNewType("nop"))}),
9495
},
9596
Arrow: ArrowConfig{
9697
NumStreams: 2,

exporter/otelarrowexporter/factory_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import (
1616
"go.opentelemetry.io/collector/config/configcompression"
1717
"go.opentelemetry.io/collector/config/configgrpc"
1818
"go.opentelemetry.io/collector/config/configopaque"
19+
"go.opentelemetry.io/collector/config/configoptional"
1920
"go.opentelemetry.io/collector/config/configretry"
2021
"go.opentelemetry.io/collector/config/configtls"
2122
"go.opentelemetry.io/collector/exporter/exporterhelper"
@@ -94,11 +95,11 @@ func TestCreateTraces(t *testing.T) {
9495
config: Config{
9596
ClientConfig: configgrpc.ClientConfig{
9697
Endpoint: endpoint,
97-
Keepalive: &configgrpc.KeepaliveClientConfig{
98+
Keepalive: configoptional.Some(configgrpc.KeepaliveClientConfig{
9899
Time: 30 * time.Second,
99100
Timeout: 25 * time.Second,
100101
PermitWithoutStream: true,
101-
},
102+
}),
102103
},
103104
},
104105
},

exporter/otelarrowexporter/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ require (
1515
go.opentelemetry.io/collector/config/configcompression v1.35.1-0.20250708151327-74cb2f311035
1616
go.opentelemetry.io/collector/config/configgrpc v0.129.1-0.20250708151327-74cb2f311035
1717
go.opentelemetry.io/collector/config/configopaque v1.35.1-0.20250708151327-74cb2f311035
18+
go.opentelemetry.io/collector/config/configoptional v0.129.0
1819
go.opentelemetry.io/collector/config/configretry v1.35.1-0.20250708151327-74cb2f311035
1920
go.opentelemetry.io/collector/config/configtls v1.35.1-0.20250708151327-74cb2f311035
2021
go.opentelemetry.io/collector/confmap v1.35.1-0.20250708151327-74cb2f311035
@@ -77,7 +78,6 @@ require (
7778
go.opentelemetry.io/auto/sdk v1.1.0 // indirect
7879
go.opentelemetry.io/collector/config/configmiddleware v0.129.1-0.20250708151327-74cb2f311035 // indirect
7980
go.opentelemetry.io/collector/config/confignet v1.35.1-0.20250708151327-74cb2f311035 // indirect
80-
go.opentelemetry.io/collector/config/configoptional v0.129.0 // indirect
8181
go.opentelemetry.io/collector/consumer/consumertest v0.129.1-0.20250708151327-74cb2f311035 // indirect
8282
go.opentelemetry.io/collector/consumer/xconsumer v0.129.1-0.20250708151327-74cb2f311035 // indirect
8383
go.opentelemetry.io/collector/exporter/xexporter v0.129.1-0.20250708151327-74cb2f311035 // indirect

exporter/otelarrowexporter/otelarrow.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,9 +138,9 @@ func (e *baseExporter) start(ctx context.Context, host component.Host) (err erro
138138
ctx := e.enhanceContext(context.Background())
139139

140140
var perRPCCreds credentials.PerRPCCredentials
141-
if e.config.Auth != nil {
141+
if e.config.Auth.HasValue() {
142142
// Get the auth extension, we'll use it to enrich the request context.
143-
authClient, err := e.config.Auth.GetGRPCClientAuthenticator(ctx, host.GetExtensions())
143+
authClient, err := e.config.Auth.Get().GetGRPCClientAuthenticator(ctx, host.GetExtensions())
144144
if err != nil {
145145
return err
146146
}

exporter/otelarrowexporter/otelarrow_test.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import (
2626
"go.opentelemetry.io/collector/config/configauth"
2727
"go.opentelemetry.io/collector/config/configgrpc"
2828
"go.opentelemetry.io/collector/config/configopaque"
29+
"go.opentelemetry.io/collector/config/configoptional"
2930
"go.opentelemetry.io/collector/config/configtls"
3031
"go.opentelemetry.io/collector/exporter"
3132
"go.opentelemetry.io/collector/exporter/exportertest"
@@ -315,9 +316,9 @@ func TestSendTraces(t *testing.T) {
315316
Headers: map[string]configopaque.String{
316317
"header": configopaque.String(expectedHeader[0]),
317318
},
318-
Auth: &configauth.Config{
319+
Auth: configoptional.Some(configauth.Config{
319320
AuthenticatorID: authID,
320-
},
321+
}),
321322
}
322323
// This test fails w/ Arrow enabled because the function
323324
// passed to newTestAuthExtension() below requires it the
@@ -924,9 +925,9 @@ func testSendArrowTraces(t *testing.T, clientWaitForReady, streamServiceAvailabl
924925
Headers: map[string]configopaque.String{
925926
"header": configopaque.String(expectedHeader[0]),
926927
},
927-
Auth: &configauth.Config{
928+
Auth: configoptional.Some(configauth.Config{
928929
AuthenticatorID: authID,
929-
},
930+
}),
930931
}
931932
// Arrow client is enabled, but the server doesn't support it.
932933
cfg.Arrow.NumStreams = 1

0 commit comments

Comments
 (0)