You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
test: use the real 22.7.0 AsyncContextFrame cutoff
Review nits from #397. AsyncContextFrame landed in 22.7.0, not at the 22
boundary, so several places named the wrong version.
Drop `&& satisfies(process.versions.node, '>=22.7.0')` from the four useCPED
definitions. It is redundant against isAsyncContextFrameActive(): ACF cannot be
active below 22.7.0, so the detection already answers false there. This leaves
semver unused in test-get-value-from-map-profiler.ts, so the import goes too.
Fix the cutoffs that were expressed as a bare major: the skip gates in
test-async-context-frame.ts now use a semver check, and the prose in
test-otel-thread-ctx.ts and in the async-context-frame doc comment names
22.7.0.
asyncContextFrameHint() had the only user-visible instance of the bug: on Node
22.0 through 22.6 it advised passing --experimental-async-context-frame, a flag
those versions do not have. Compared by major/minor rather than
semver.satisfies because semver is a devDependency and this module ships.
Boundary checked across 20.19.0, 22.6.0, 22.7.0, 22.23.2, 23.5.0 and 24.18.0.
124 passing on macOS, 175 passing / 2 pending in test:docker, unchanged.
0 commit comments