refactor(scripts): share ruff setup in ruff-common.sh

Author: vlad-scherbich

scripts/format

@@ -1,19 +1,9 @@
 #!/usr/bin/env bash
 set -euo pipefail
 
-root="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
-cd "$root"
-dev_requirements="$root/requirements-dev.txt"
+source "$(dirname "${BASH_SOURCE[0]}")/ruff-common.sh"
+ruff_common_setup
+ruff_resolve_targets "$@"
 
-if ! command -v ruff >/dev/null 2>&1; then
-  echo "ruff not found; install with: pip install -r $dev_requirements" >&2
-  exit 1
-fi
-
-targets=("$@")
-if [ "${#targets[@]}" -eq 0 ]; then
-  targets=(".")
-fi
-
-ruff check --fix "${targets[@]}"
-ruff format "${targets[@]}"
+ruff check --fix "${RUFF_TARGETS[@]}"
+ruff format "${RUFF_TARGETS[@]}"

scripts/lint

@@ -2,19 +2,9 @@
 set -euo pipefail
 
 # Matches the ruff job in .github/workflows/ci.yml (see also scripts/format).
-root="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
-cd "$root"
-dev_requirements="$root/requirements-dev.txt"
+source "$(dirname "${BASH_SOURCE[0]}")/ruff-common.sh"
+ruff_common_setup
+ruff_resolve_targets "$@"
 
-if ! command -v ruff >/dev/null 2>&1; then
-  echo "ruff not found; install with: pip install -r $dev_requirements" >&2
-  exit 1
-fi
-
-targets=("$@")
-if [ "${#targets[@]}" -eq 0 ]; then
-  targets=(".")
-fi
-
-ruff format --check "${targets[@]}"
-ruff check "${targets[@]}"
+ruff format --check "${RUFF_TARGETS[@]}"
+ruff check "${RUFF_TARGETS[@]}"

scripts/ruff-common.sh

@@ -0,0 +1,17 @@
+# Shared setup for scripts/lint and scripts/format.
+ruff_common_setup() {
+  RUFF_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+  cd "$RUFF_ROOT"
+
+  if ! command -v ruff >/dev/null 2>&1; then
+    echo "ruff not found; install with: pip install -r $RUFF_ROOT/requirements-dev.txt" >&2
+    exit 1
+  fi
+}
+
+ruff_resolve_targets() {
+  RUFF_TARGETS=("$@")
+  if [ "${#RUFF_TARGETS[@]}" -eq 0 ]; then
+    RUFF_TARGETS=(".")
+  fi
+}