Merge pull request #86 from datadog-labs/fix/events-search-oauth

fix(events): use API key auth for events v2 search endpoint

Author: platinummonkey

cmd/events.go

@@ -120,7 +120,8 @@ func runEventsList(cmd *cobra.Command, args []string) error {
 }
 
 func runEventsSearch(cmd *cobra.Command, args []string) error {
-	client, err := getClient()
+	// Events V2 search does not support OAuth, requires API keys
+	client, err := getClientForEndpoint("POST", "/api/v2/events/search")
 	if err != nil {
 		return err
 	}

pkg/client/auth_validator.go

@@ -61,6 +61,9 @@ var endpointsWithoutOAuth = []EndpointAuthRequirement{
 	{Path: "/api/v2/app_keys/", Method: "POST", SupportsOAuth: false, RequiresAPIKeys: true, Reason: "App Keys management missing OAuth implementation in spec"},
 	{Path: "/api/v2/app_keys/", Method: "DELETE", SupportsOAuth: false, RequiresAPIKeys: true, Reason: "App Keys management missing OAuth implementation in spec"},
 
+	// Events V2 Search API - OAuth not supported
+	{Path: "/api/v2/events/search", Method: "POST", SupportsOAuth: false, RequiresAPIKeys: true, Reason: "Events V2 search API does not support OAuth authentication"},
+
 	// Error Tracking API - OAuth not working in practice
 	{Path: "/api/v2/error_tracking/issues/search", Method: "POST", SupportsOAuth: false, RequiresAPIKeys: true, Reason: "Error Tracking API requires API keys"},
 	{Path: "/api/v2/error_tracking/issues/", Method: "GET", SupportsOAuth: false, RequiresAPIKeys: true, Reason: "Error Tracking API requires API keys"},

pkg/client/auth_validator_test.go

@@ -86,6 +86,12 @@ func TestRequiresAPIKeyFallback(t *testing.T) {
 			path:     "/api/v2/error_tracking/issues/abc123",
 			expected: true,
 		},
+		{
+			name:     "events v2 search requires API keys",
+			method:   "POST",
+			path:     "/api/v2/events/search",
+			expected: true,
+		},
 		{
 			name:     "monitors list supports OAuth",
 			method:   "GET",