Merge pull request #74 from DataDog/fix/version-ldflags

fix(version): correct ldflags variable names for build metadata

Author: platinummonkey

.goreleaser.yml

@@ -33,9 +33,8 @@ builds:
     ldflags:
       - -s -w
       - -X github.com/DataDog/pup/internal/version.Version={{.Version}}
-      - -X github.com/DataDog/pup/internal/version.Commit={{.Commit}}
-      - -X github.com/DataDog/pup/internal/version.Date={{.Date}}
-      - -X github.com/DataDog/pup/internal/version.BuiltBy=goreleaser
+      - -X github.com/DataDog/pup/internal/version.GitCommit={{.Commit}}
+      - -X github.com/DataDog/pup/internal/version.BuildDate={{.Date}}
 
 archives:
   - id: pup

Makefile

@@ -17,9 +17,8 @@ DATE := $(shell date -u +"%Y-%m-%dT%H:%M:%SZ")
 # Build flags
 LDFLAGS := -s -w \
 	-X github.com/DataDog/pup/internal/version.Version=$(VERSION) \
-	-X github.com/DataDog/pup/internal/version.Commit=$(COMMIT) \
-	-X github.com/DataDog/pup/internal/version.Date=$(DATE) \
-	-X github.com/DataDog/pup/internal/version.BuiltBy=makefile
+	-X github.com/DataDog/pup/internal/version.GitCommit=$(COMMIT) \
+	-X github.com/DataDog/pup/internal/version.BuildDate=$(DATE)
 
 # Go build flags
 GO_BUILD_FLAGS := -trimpath -ldflags "$(LDFLAGS)"