Skip to content

Commit 1292d02

Browse files
committed
πŸ‘Œ Make overwritten optional in AddViewLoadingTime telemetry
1 parent 184e211 commit 1292d02

4 files changed

Lines changed: 4 additions & 5 deletions

File tree

β€Žlib/cjs/generated/telemetry.d.tsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -848,7 +848,7 @@ export interface AddViewLoadingTime {
848848
/**
849849
* Whether this call overwrote a previously set loading time
850850
*/
851-
overwritten: boolean;
851+
overwritten?: boolean;
852852
[k: string]: unknown;
853853
}
854854
export interface StartSessionReplayRecording {

β€Žlib/esm/generated/telemetry.d.tsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -848,7 +848,7 @@ export interface AddViewLoadingTime {
848848
/**
849849
* Whether this call overwrote a previously set loading time
850850
*/
851-
overwritten: boolean;
851+
overwritten?: boolean;
852852
[k: string]: unknown;
853853
}
854854
export interface StartSessionReplayRecording {

β€Žsamples/telemetry-events/usage-add-view-loading-time-browser.jsonβ€Ž

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@
2323
"telemetry": {
2424
"type": "usage",
2525
"usage": {
26-
"feature": "addViewLoadingTime",
27-
"overwritten": true
26+
"feature": "addViewLoadingTime"
2827
}
2928
}
3029
}

β€Žschemas/telemetry/usage/common-features-schema.jsonβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@
313313
}
314314
},
315315
{
316-
"required": ["feature", "overwritten"],
316+
"required": ["feature"],
317317
"title": "AddViewLoadingTime",
318318
"properties": {
319319
"feature": {

0 commit comments

Comments
Β (0)