Skip to content

Commit e2a11df

Browse files
committed
Remove overwrite property, keep only overwritten
Revert the overwrite property addition — it adds unnecessary complexity to the schema. The overwritten property already captures the relevant runtime information.
1 parent 7ad316d commit e2a11df

5 files changed

Lines changed: 1 addition & 15 deletions

File tree

lib/cjs/generated/telemetry.d.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -837,10 +837,6 @@ export interface AddViewLoadingTime {
837837
* addViewLoadingTime API
838838
*/
839839
feature: 'addViewLoadingTime';
840-
/**
841-
* Whether the overwrite API option was used
842-
*/
843-
overwrite: boolean;
844840
/**
845841
* Whether the view is not available
846842
*/

lib/esm/generated/telemetry.d.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -837,10 +837,6 @@ export interface AddViewLoadingTime {
837837
* addViewLoadingTime API
838838
*/
839839
feature: 'addViewLoadingTime';
840-
/**
841-
* Whether the overwrite API option was used
842-
*/
843-
overwrite: boolean;
844840
/**
845841
* Whether the view is not available
846842
*/

samples/telemetry-events/usage-add-view-loading-time-browser.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
"type": "usage",
2525
"usage": {
2626
"feature": "addViewLoadingTime",
27-
"overwrite": true,
2827
"overwritten": true
2928
}
3029
}

samples/telemetry-events/usage-add-view-loading-time-mobile.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
"type": "usage",
2525
"usage": {
2626
"feature": "addViewLoadingTime",
27-
"overwrite": false,
2827
"no_view": true,
2928
"overwritten": false
3029
}

schemas/telemetry/usage/common-features-schema.json

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -313,18 +313,14 @@
313313
}
314314
},
315315
{
316-
"required": ["feature", "overwrite", "overwritten"],
316+
"required": ["feature", "overwritten"],
317317
"title": "AddViewLoadingTime",
318318
"properties": {
319319
"feature": {
320320
"type": "string",
321321
"description": "addViewLoadingTime API",
322322
"const": "addViewLoadingTime"
323323
},
324-
"overwrite": {
325-
"type": "boolean",
326-
"description": "Whether the overwrite API option was used"
327-
},
328324
"no_view": {
329325
"type": "boolean",
330326
"description": "Whether the view is not available"

0 commit comments

Comments
 (0)