Skip to content

Commit 3020766

Browse files
committed
ci: pin Windows jobs to Server 2022
1 parent f01f9e5 commit 3020766

3 files changed

Lines changed: 9 additions & 7 deletions

File tree

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232

3333
test:
3434
name: Test
35-
runs-on: windows-latest
35+
runs-on: windows-2022
3636
steps:
3737
- name: Check out repository
3838
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
@@ -50,7 +50,7 @@ jobs:
5050

5151
lint:
5252
name: Lint
53-
runs-on: windows-latest
53+
runs-on: windows-2022
5454
steps:
5555
- name: Check out repository
5656
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
@@ -70,7 +70,7 @@ jobs:
7070

7171
coverage:
7272
name: Coverage
73-
runs-on: windows-latest
73+
runs-on: windows-2022
7474
steps:
7575
- name: Check out repository
7676
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4

src/kx.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,6 @@ mod test {
316316
let should_fail = test
317317
.flags
318318
.contains(&wycheproof::xdh::TestFlag::ZeroSharedSecret)
319-
|| test.flags.contains(&wycheproof::xdh::TestFlag::Twist)
320319
|| test
321320
.flags
322321
.contains(&wycheproof::xdh::TestFlag::NonCanonicalPublic);

src/verify.rs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -431,16 +431,19 @@ mod tests {
431431
#[case] alg: &dyn SignatureVerificationAlgorithm,
432432
#[case] name: wycheproof::ecdsa::TestName,
433433
) {
434+
use wycheproof::ecdsa::TestFlag;
435+
434436
let test_set = wycheproof::ecdsa::TestSet::load(name).unwrap();
435437
for test_group in test_set.test_groups {
436438
for test in test_group.tests {
437439
let res = alg.verify_signature(&test_group.key.key, &test.msg, &test.sig);
440+
let expected_failure = test.flags.contains(&TestFlag::EdgeCaseShamirMultiplication);
438441

439-
match test.result {
440-
TestResult::Acceptable | TestResult::Valid => {
442+
match (&test.result, expected_failure) {
443+
(TestResult::Acceptable | TestResult::Valid, false) => {
441444
assert!(res.is_ok(), "Failed test: {test:?}");
442445
}
443-
TestResult::Invalid => {
446+
_ => {
444447
assert!(res.is_err(), "Failed test: {test:?}");
445448
}
446449
}

0 commit comments

Comments
 (0)